Handle trailing alpha in version()

krayon · krayon · commit aa0617db68fd · 2023-03-25T02:46:23.000+11:00
diff --git a/share/github-backup-utils/ghe-backup-config b/share/github-backup-utils/ghe-backup-config
@@ -510,8 +510,9 @@ ghe_debug() {
 version() {
   local v="${*#v}"
 
+  # Discard stderr and always return true as trailing alpha (eg. "v1.2.3pre") will upset printf
   # shellcheck disable=SC2183,SC2086 # We want to glob (SC2086) and expect 4 (fuzzy) params (SC2183)
-  printf "%d%03d%03d%03d\n" ${v//./ }
+  printf "%d%03d%03d%03d\n" ${v//./ } 2>/dev/null || true
 }
 
 # The list of gists returned by the source changed in 2.16.23, 2.17.14,

Original file line number	Diff line number	Diff line change
`@@ -510,8 +510,9 @@ ghe_debug() {`
`510`	`510`	`version() {`
`511`	`511`	`local v="${*#v}"`
`512`	`512`
	`513`	`+ # Discard stderr and always return true as trailing alpha (eg. "v1.2.3pre") will upset printf`
`513`	`514`	`# shellcheck disable=SC2183,SC2086 # We want to glob (SC2086) and expect 4 (fuzzy) params (SC2183)`
`514`		`- printf "%d%03d%03d%03d\n" ${v//./ }`
	`515`	`+ printf "%d%03d%03d%03d\n" ${v//./ } 2>/dev/null \|\| true`
`515`	`516`	`}`
`516`	`517`
`517`	`518`	`# The list of gists returned by the source changed in 2.16.23, 2.17.14,`