Fix a few bugs in the rsync function

Make the switch to use files-from or -z option based on file extension.

Author: sridharavinash

share/github-backup-utils/ghe-backup-repositories-cluster-ng

@@ -147,17 +147,31 @@ fi
 rsync_repository_data () {
   port=$(ssh_port_part "$1")
   host=$(ssh_host_part "$1")
-  file_list="$2"
-  shift
-  shift
-  ghe-rsync -avr \
-    -e "ssh -q $opts -p $port -F $config_file -l $user" \
-    $link_dest "$@" \
-    --rsync-path='sudo -u git rsync' \
-	  --include-from=- --exclude=\* \
-	  --files-from="$file_list" \
-    "$host:$GHE_REMOTE_DATA_USER_DIR/repositories/" \
-    "$backup_dir" 1>&3
+
+  #check if we are syncing from a given file list
+  if [[ "$2" == *".rsync" ]]; then
+    files_list="$2"
+    shift
+    shift
+    ghe-rsync -avr \
+      -e "ssh -q $opts -p $port -F $config_file -l $user" \
+      $link_dest "$@" \
+      --rsync-path='sudo -u git rsync' \
+      --include-from=- --exclude=\* \
+      --files-from="$files_list" \
+      "$host:$GHE_REMOTE_DATA_USER_DIR/repositories/" \
+      "$backup_dir" 1>&3
+  else
+    shift
+    ghe-rsync -avr \
+      -e "ssh -q $opts -p $port -F $config_file -l $user" \
+      $link_dest "$@" \
+      --rsync-path='sudo -u git rsync' \
+      --include-from=- --exclude=\* \
+      "$host:$GHE_REMOTE_DATA_USER_DIR/repositories/" \
+      "$backup_dir" 1>&3
+  fi
+
 }
 
 sync_data (){