Add unit test for track progress (#659)

* Add unit test for track progress

* add end_test

* change test and fix init-progress

* Make the test go green

* Update ghe-backup-config

Author: gamefiend

share/github-backup-utils/ghe-backup-config

@@ -661,17 +661,13 @@ prompt_for_confirmation(){
 
 #initialize progress tracking by clearing out the temp files used to track
 init-progress() {
-  if [ -d /tmp/backup-utils-progress ]; then
+
+  if [ -e /tmp/backup-utils-progress ]; then
     rm -rf /tmp/backup-utils-progress/*
   fi
-
-  mkdir -p /tmp/backup-utils-progress
-  chmod -R 777 /tmp/backup-utils-progress
-  
-  touch /tmp/backup-utils-progress/total
-  touch /tmp/backup-utils-progress/type
-  touch /tmp/backup-utils-progress/progress
-  touch /tmp/backup-utils-progress/info
+  # shellcheck disable=SC2174 # We are fine with -m only affecting the deepest directory
+  mkdir -m 777 -p /tmp/backup-utils-progress
+  touch /tmp/backup-utils-progress/{total,type,progress,info}
 }
 
 

test/test-ghe-backup.sh

@@ -1074,3 +1074,18 @@ begin_test "ghe-backup collects information on system where backup-utils is inst
 
 )
 end_test
+
+# Check that backup-utils manages track-progress folder correctly
+begin_test "ghe-backup manages progress tracking files properly"
+(
+  set -e
+
+  if [ -e /tmp/backup-utils-progress ]; then
+    rm -rf /tmp/backup-utils-progress/*
+  fi
+
+  output=$(ghe-backup)
+  echo "$output" | grep -v "mkdir: cannot create directory /tmp/backup-utils-progress: File exists"  
+
+)
+end_test