Skip to content

Commit 0e1ad53

Browse files
committed
Fix sarif-ids format not matching documentation
1 parent 4c60b18 commit 0e1ad53

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

.github/workflows/__upload-quality-sarif.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/upload-sarif-action.js

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/checks/upload-quality-sarif.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ steps:
2222
ref: 'refs/heads/main'
2323
sha: '5e235361806c361d4d3f8859e3c897658025a9a2'
2424
- name: "Check output from `upload-sarif` step"
25-
if: fromJSON(steps.upload-sarif.outputs.sarif-ids)[0].analysis != 'code-quality'
25+
if: !fromJSON(steps.upload-sarif.outputs.sarif-ids).code-quality
2626
run: exit 1

src/upload-sarif.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,10 @@ export async function uploadSarif(
101101

102102
export function uploadResultsToSarifIds(
103103
uploadResults: UploadSarifResults,
104-
): UploadSarifResult[] {
105-
return Object.entries(uploadResults).map(([analysisKind, result]) => ({
106-
analysis: analysisKind as analyses.AnalysisKind,
107-
id: result.sarifID,
108-
}));
104+
): Partial<Record<analyses.AnalysisKind, string>> {
105+
const result = {};
106+
for (const uploadResult of Object.keys(uploadResults)) {
107+
result[uploadResult] = uploadResults[uploadResult].id;
108+
}
109+
return result;
109110
}

0 commit comments

Comments
 (0)