Skip to content

Commit 1bfb67d

Browse files
committed
Refactor combining queries into its own function
1 parent 781a65a commit 1bfb67d

File tree

2 files changed

+39
-13
lines changed

2 files changed

+39
-13
lines changed

lib/init-action.js

Lines changed: 11 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/config/db-config.ts

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -361,23 +361,42 @@ function parseQueriesFromInput(
361361
return trimmedInput.split(",").map((query) => ({ uses: query.trim() }));
362362
}
363363

364-
export function generateCodeScanningConfig(
365-
originalUserInput: UserConfig,
364+
/**
365+
* Combines queries from various configuration sources.
366+
*
367+
* @param augmentedConfig The loaded configuration file (either `config-file` or `config` input).
368+
* @param augmentationProperties Additional configuration data from other sources.
369+
* @returns Returns `augmentedConfig` with `queries` set to the computed array of queries.
370+
*/
371+
function combineQueries(
372+
augmentedConfig: UserConfig,
366373
augmentationProperties: AugmentationProperties,
367-
): UserConfig {
368-
// make a copy so we can modify it
369-
const augmentedConfig = cloneObject(originalUserInput);
370-
371-
// Inject the queries from the input
374+
): QuerySpec[] | undefined {
372375
if (augmentationProperties.queriesInput) {
373376
if (augmentationProperties.queriesInputCombines) {
374-
augmentedConfig.queries = (augmentedConfig.queries || []).concat(
377+
return (augmentedConfig.queries || []).concat(
375378
augmentationProperties.queriesInput,
376379
);
377380
} else {
378-
augmentedConfig.queries = augmentationProperties.queriesInput;
381+
return augmentationProperties.queriesInput;
379382
}
380383
}
384+
385+
return augmentedConfig.queries;
386+
}
387+
388+
export function generateCodeScanningConfig(
389+
originalUserInput: UserConfig,
390+
augmentationProperties: AugmentationProperties,
391+
): UserConfig {
392+
// make a copy so we can modify it
393+
const augmentedConfig = cloneObject(originalUserInput);
394+
395+
// Inject the queries from the input
396+
augmentedConfig.queries = combineQueries(
397+
augmentedConfig,
398+
augmentationProperties,
399+
);
381400
if (augmentedConfig.queries?.length === 0) {
382401
delete augmentedConfig.queries;
383402
}

0 commit comments

Comments
 (0)