Skip to content

Commit 1f0a037

Browse files
committed
Address PR review, clean up comments
1 parent 762301c commit 1f0a037

8 files changed

+15
-26
lines changed

.github/workflows/__all-platform-bundle.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__multi-language-autodetect.yml

Lines changed: 5 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__test-local-codeql.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__unset-environment.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/checks/all-platform-bundle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ steps:
77
- id: init
88
uses: ./../action/init
99
with:
10-
# We manually exclude Swift from the languages list here, as it is not supported on Ubuntu
10+
# Swift is not supported on Ubuntu so we manually exclude it from the list here
1111
languages: cpp,csharp,go,java,javascript,python,ruby
1212
tools: ${{ steps.prepare-test.outputs.tools-url }}
1313
- name: Build code

pr-checks/checks/multi-language-autodetect.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,17 @@ steps:
77
go-version: ">=1.21.0"
88

99
- uses: ./../action/init
10-
if: runner.os == 'Linux'
11-
with:
12-
db-location: "${{ runner.temp }}/customDbLocation"
13-
# We manually exclude Swift from the languages list here, as it is not supported on Ubuntu
14-
languages: cpp,csharp,go,java,javascript,python,ruby
15-
tools: ${{ steps.prepare-test.outputs.tools-url }}
16-
17-
- uses: ./../action/init
18-
id: init-macos
19-
if: runner.os == 'macOS'
10+
id: init
2011
with:
2112
db-location: "${{ runner.temp }}/customDbLocation"
13+
# Swift is not supported on Ubuntu so we manually exclude it from the list here
14+
languages: ${{ runner.os == 'Linux' && 'cpp,csharp,go,java,javascript,python,ruby' || '' }}
2215
tools: ${{ steps.prepare-test.outputs.tools-url }}
2316

2417
- uses: ./../action/.github/actions/setup-swift
2518
if: runner.os == 'macOS'
2619
with:
27-
codeql-path: ${{ steps.init-macos.outputs.codeql-path }}
20+
codeql-path: ${{ steps.init.outputs.codeql-path }}
2821

2922
- name: Build code
3023
shell: bash

pr-checks/checks/test-local-codeql.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ steps:
1212
- id: init
1313
uses: ./../action/init
1414
with:
15+
# Swift is not supported on Ubuntu so we manually exclude it from the list here
1516
languages: cpp,csharp,go,java,javascript,python,ruby
1617
tools: ./codeql-bundle-linux64.tar.gz
1718
- name: Build code

pr-checks/checks/unset-environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ steps:
77
id: init
88
with:
99
db-location: ${{ runner.temp }}/customDbLocation
10-
# We manually exclude Swift from the languages list here, as it is not supported on Ubuntu
10+
# Swift is not supported on Ubuntu so we manually exclude it from the list here
1111
languages: cpp,csharp,go,java,javascript,python,ruby
1212
tools: ${{ steps.prepare-test.outputs.tools-url }}
1313
- uses: actions/setup-go@v5

0 commit comments

Comments
 (0)