Skip to content

Commit 1f4b0cb

Browse files
committed
Add regression test
1 parent b07135c commit 1f4b0cb

File tree

6 files changed

+20
-3
lines changed

6 files changed

+20
-3
lines changed

lib/setup-codeql.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/setup-codeql.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/setup-codeql.test.js

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/setup-codeql.test.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/setup-codeql.test.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,3 +249,13 @@ test("setupCodeQLBundle logs the CodeQL CLI version being used when asked to dow
249249
);
250250
});
251251
});
252+
253+
test('tryGetTagNameFromUrl extracts the right tag name for a repo name containing "codeql-bundle"', (t) => {
254+
t.is(
255+
setupCodeql.tryGetTagNameFromUrl(
256+
"https://github.com/org/codeql-bundle-testing/releases/download/codeql-bundle-v2.19.0/codeql-bundle-linux64.tar.zst",
257+
getRunnerLogger(true),
258+
),
259+
"codeql-bundle-v2.19.0",
260+
);
261+
});

src/setup-codeql.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,10 @@ function tryGetBundleVersionFromTagName(
138138
return match[1];
139139
}
140140

141-
function tryGetTagNameFromUrl(url: string, logger: Logger): string | undefined {
141+
export function tryGetTagNameFromUrl(
142+
url: string,
143+
logger: Logger,
144+
): string | undefined {
142145
const matches = [...url.matchAll(/\/(codeql-bundle-[^/]*)\//g)];
143146
if (!matches.length) {
144147
logger.debug(`Could not determine tag name for URL ${url}.`);

0 commit comments

Comments
 (0)