Skip to content

Commit 28f2516

Browse files
committed
Improve Rust analysis PR check
Also run the `rust` checks on "milestone" CLI releases, to ensure we remain backward compatible with those versions. This was prompted by #2960 (review) Running this on current `main` and then on that PR should improve our confidence we remain backward compatible. It also turns out a probable `ruamel.yaml` update was changing a lot of generated workflows, so I've: * fixed the `ruamel.yaml` version to the latest in `sync.sh` * added `yaml.width = 120` in `sync.py` to minimize (but not entirely remove) the number of changes * checked in the workflows whose formatting was changed by the new `ruamel.yaml` version
1 parent 4474150 commit 28f2516

File tree

8 files changed

+19
-15
lines changed

8 files changed

+19
-15
lines changed

.github/workflows/__multi-language-autodetect.yml

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__packaging-inputs-js.yml

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__resolve-environment-action.yml

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__rust.yml

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__start-proxy.yml

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/checks/rust.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
name: "Rust analysis"
22
description: "Tests creation of a Rust database"
3-
versions: ["linked", "default", "nightly-latest"]
3+
versions:
4+
- stable-v2.19.3 # experimental rust support introduced, requires action to set `CODEQL_ENABLE_EXPERIMENTAL_FEATURES`
5+
- stable-v2.22.1 # first public preview version
6+
- linked
7+
- default
8+
- nightly-latest
49
operatingSystems: ["ubuntu"]
510
steps:
611
- uses: ./../action/init
712
with:
813
languages: rust
914
tools: ${{ steps.prepare-test.outputs.tools-url }}
10-
env:
11-
CODEQL_ACTION_RUST_ANALYSIS: true
1215
- uses: ./../action/analyze
1316
id: analysis
1417
with:

pr-checks/sync.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ def writeHeader(checkStream):
5656
yaml = ruamel.yaml.YAML()
5757
yaml.Representer = NonAliasingRTRepresenter
5858
yaml.indent(mapping=2, sequence=4, offset=2)
59+
yaml.width = 120
5960

6061
this_dir = pathlib.Path(__file__).resolve().parent
6162

pr-checks/sync.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ set -e
44
cd "$(dirname "$0")"
55
python3 -m venv env
66
source env/bin/activate
7-
pip3 install ruamel.yaml
7+
pip3 install ruamel.yaml==0.18.14
88
python3 sync.py
99

0 commit comments

Comments
 (0)