Skip to content

Commit 2969f87

Browse files
committed
Call getSupportedLanguageMap() outside getLanguages()
1 parent 76be57f commit 2969f87

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/config-utils.test.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,14 +1163,18 @@ const mockRepositoryNwo = parseRepositoryNwo("owner/repo");
11631163
}),
11641164
});
11651165

1166+
const languageMap = await configUtils.getSupportedLanguageMap(
1167+
codeQL,
1168+
features,
1169+
mockLogger,
1170+
);
11661171
if (args.expectedLanguages) {
11671172
// happy path
11681173
const actualLanguages = await configUtils.getLanguages(
1169-
codeQL,
1174+
languageMap,
11701175
args.languagesInput,
11711176
mockRepositoryNwo,
11721177
".",
1173-
features,
11741178
mockLogger,
11751179
);
11761180

@@ -1180,11 +1184,10 @@ const mockRepositoryNwo = parseRepositoryNwo("owner/repo");
11801184
await t.throwsAsync(
11811185
async () =>
11821186
await configUtils.getLanguages(
1183-
codeQL,
1187+
languageMap,
11841188
args.languagesInput,
11851189
mockRepositoryNwo,
11861190
".",
1187-
features,
11881191
mockLogger,
11891192
),
11901193
{ message: args.expectedError },

src/config-utils.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -443,11 +443,10 @@ export async function getRawLanguagesInRepo(
443443
* then throw an error.
444444
*/
445445
export async function getLanguages(
446-
codeql: CodeQL,
446+
languageMap: Record<string, string>,
447447
languagesInput: string | undefined,
448448
repository: RepositoryNwo,
449449
sourceRoot: string,
450-
features: FeatureEnablement,
451450
logger: Logger,
452451
): Promise<Language[]> {
453452
// Obtain languages without filtering them.
@@ -457,8 +456,6 @@ export async function getLanguages(
457456
sourceRoot,
458457
logger,
459458
);
460-
461-
const languageMap = await getSupportedLanguageMap(codeql, features, logger);
462459
const languagesSet = new Set<Language>();
463460
const unknownLanguages: string[] = [];
464461

@@ -600,12 +597,12 @@ export async function initActionState(
600597
analysisKinds.push(AnalysisKind.CodeQuality);
601598
}
602599

600+
const languageMap = await getSupportedLanguageMap(codeql, features, logger);
603601
const languages = await getLanguages(
604-
codeql,
602+
languageMap,
605603
languagesInput,
606604
repository,
607605
sourceRoot,
608-
features,
609606
logger,
610607
);
611608

0 commit comments

Comments
 (0)