Add test for modified findSarifFilesInDir

Author: mbg

lib/upload-lib.js

@@ -122,6 +122,10 @@ test("finding SARIF files", async (t) => {
       "file",
     );
 
+    // add some `.quality.sarif` files that should be ignored, unless we look for them specifically
+    fs.writeFileSync(path.join(tmpDir, "a.quality.sarif"), "");
+    fs.writeFileSync(path.join(tmpDir, "dir1", "b.quality.sarif"), "");
+
     const sarifFiles = uploadLib.findSarifFilesInDir(tmpDir);
 
     t.deepEqual(sarifFiles, [
@@ -130,6 +134,16 @@ test("finding SARIF files", async (t) => {
       path.join(tmpDir, "dir1", "d.sarif"),
       path.join(tmpDir, "dir1", "dir2", "e.sarif"),
     ]);
+
+    const qualitySarifFiles = uploadLib.findSarifFilesInDir(
+      tmpDir,
+      uploadLib.qualityIsSarif,
+    );
+
+    t.deepEqual(qualitySarifFiles, [
+      path.join(tmpDir, "a.quality.sarif"),
+      path.join(tmpDir, "dir1", "b.quality.sarif"),
+    ]);
   });
 });
 

lib/upload-lib.js.map

@@ -380,8 +380,8 @@ export interface UploadResult {
   sarifID: string;
 }
 
-const qualityIsSarif = (name: string) => name.endsWith(".quality.sarif");
-const defaultIsSarif = (name: string) =>
+export const qualityIsSarif = (name: string) => name.endsWith(".quality.sarif");
+export const defaultIsSarif = (name: string) =>
   name.endsWith(".sarif") && !qualityIsSarif(name);
 
 // Recursively walks a directory and returns all SARIF files it finds.