getPullRequestEditedDiffRanges: compute diff ranges

Author: cklin

src/analyze.ts

@@ -294,8 +294,19 @@ async function getPullRequestEditedDiffRanges(
   headLabel: string,
   logger: Logger,
 ): Promise<DiffThunkRange[] | undefined> {
-  await getFileDiffsWithBasehead(baseRef, headLabel, logger);
-  return undefined;
+  const filediffs = await getFileDiffsWithBasehead(baseRef, headLabel, logger);
+  if (filediffs === undefined) {
+    return undefined;
+  }
+  const results: DiffThunkRange[] = [];
+  for (const filediff of filediffs) {
+    const diffRanges = getDiffRanges(filediff, logger);
+    if (diffRanges === undefined) {
+      return undefined;
+    }
+    results.push(...diffRanges);
+  }
+  return results;
 }
 
 /**
@@ -345,6 +356,73 @@ async function getFileDiffsWithBasehead(
   }
 }
 
+function getDiffRanges(
+  fileDiff: FileDiff,
+  logger: Logger,
+): DiffThunkRange[] | undefined {
+  if (fileDiff.patch === undefined) {
+    return undefined;
+  }
+
+  // Diff-informed queries expect the file path to be absolute.
+  const filename = path.join(
+    actionsUtil.getRequiredInput("checkout_path"),
+    fileDiff.filename,
+  );
+
+  let currentLine = 0;
+  let additionRangeStartLine: number | undefined = undefined;
+  const diffRanges: DiffThunkRange[] = [];
+
+  const lines = fileDiff.patch.split("\n");
+  // Adding a fake context line at the end ensures that the following loop will
+  // always terminate the last range of added lines.
+  lines.push(" ");
+
+  for (const line of lines) {
+    if (line.startsWith("-")) {
+      // Ignore deletions completely -- we do not even want to consider them when
+      // calculating consecutive ranges of added lines.
+      continue;
+    }
+    if (line.startsWith("+")) {
+      if (additionRangeStartLine === undefined) {
+        additionRangeStartLine = currentLine;
+      }
+      currentLine++;
+      continue;
+    }
+    if (additionRangeStartLine !== undefined) {
+      // Any line that does not start with a "+" or "-" terminates the current
+      // range of added lines.
+      diffRanges.push({
+        path: filename,
+        startLine: additionRangeStartLine,
+        endLine: currentLine - 1,
+      });
+      additionRangeStartLine = undefined;
+    }
+    if (line.startsWith("@@ ")) {
+      // A new hunk header line resets the current line number.
+      const match = line.match(/^@@ -\d+(?:,\d+)? \+(\d+)(?:,\d+)? @@/);
+      if (match === null) {
+        logger.warning(
+          `Cannot parse diff hunk header for ${fileDiff.filename}: ${line}`,
+        );
+        return undefined;
+      }
+      currentLine = parseInt(match[1], 10);
+      continue;
+    }
+    if (line.startsWith(" ")) {
+      // An unchanged context line advances the current line number.
+      currentLine++;
+      continue;
+    }
+  }
+  return diffRanges;
+}
+
 /**
  * Create an extension pack in the temporary directory that contains the file
  * line ranges that were added or modified in the pull request.