Skip to content

Commit bab3f2b

Browse files
committed
Remove sarifMergeRunsFromEqualCategory FF
1 parent 9924f47 commit bab3f2b

File tree

6 files changed

+0
-100
lines changed

6 files changed

+0
-100
lines changed

lib/analyze-action.js

Lines changed: 0 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action-post.js

Lines changed: 0 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/upload-lib.js

Lines changed: 0 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/upload-sarif-action.js

Lines changed: 0 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/tools-features.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export enum ToolsFeature {
99
ForceOverwrite = "forceOverwrite",
1010
IndirectTracingSupportsStaticBinaries = "indirectTracingSupportsStaticBinaries",
1111
PythonDefaultIsToNotExtractStdlib = "pythonDefaultIsToNotExtractStdlib",
12-
SarifMergeRunsFromEqualCategory = "sarifMergeRunsFromEqualCategory",
1312
}
1413

1514
/**

src/upload-lib.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import * as gitUtils from "./git-utils";
2121
import { initCodeQL } from "./init";
2222
import { Logger } from "./logging";
2323
import { getRepositoryNwo, RepositoryNwo } from "./repository";
24-
import { ToolsFeature } from "./tools-features";
2524
import * as util from "./util";
2625
import {
2726
ConfigurationError,
@@ -269,32 +268,6 @@ async function combineSarifFilesUsingCLI(
269268
codeQL = initCodeQLResult.codeql;
270269
}
271270

272-
if (
273-
!(await codeQL.supportsFeature(
274-
ToolsFeature.SarifMergeRunsFromEqualCategory,
275-
))
276-
) {
277-
await throwIfCombineSarifFilesDisabled(sarifObjects, gitHubVersion);
278-
279-
logger.warning(
280-
"The CodeQL CLI does not support merging SARIF files. Merging files in the action.",
281-
);
282-
283-
if (
284-
await shouldShowCombineSarifFilesDeprecationWarning(
285-
sarifObjects,
286-
gitHubVersion,
287-
)
288-
) {
289-
logger.warning(
290-
`Uploading multiple CodeQL runs with the same category is deprecated ${deprecationWarningMessage} for CodeQL CLI 2.16.6 and earlier. Please update your CodeQL CLI version or update your workflow to set a distinct category for each CodeQL run. ${deprecationMoreInformationMessage}`,
291-
);
292-
core.exportVariable("CODEQL_MERGE_SARIF_DEPRECATION_WARNING", "true");
293-
}
294-
295-
return combineSarifFiles(sarifFiles, logger);
296-
}
297-
298271
const baseTempDir = path.resolve(tempDir, "combined-sarif");
299272
fs.mkdirSync(baseTempDir, { recursive: true });
300273
const outputDirectory = fs.mkdtempSync(path.resolve(baseTempDir, "output-"));

0 commit comments

Comments
 (0)