Skip to content

Commit bd2ebac

Browse files
authored
Merge pull request #2340 from github/henrymercer/code-quality-improvements
Miscellaneous code quality improvements
2 parents 3990b56 + cf20090 commit bd2ebac

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+209
-181
lines changed

.eslintrc.json

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,29 +41,23 @@
4141
"ignoreTemplateLiterals": true
4242
}],
4343
"no-async-foreach/no-async-foreach": "error",
44-
"no-console": "off",
4544
"no-sequences": "error",
4645
"no-shadow": "off",
47-
"@typescript-eslint/no-shadow": ["error"],
46+
"@typescript-eslint/no-shadow": "error",
4847
"one-var": ["error", "never"]
4948
},
5049
"overrides": [{
5150
// "temporarily downgraded during transition to eslint
5251
"files": "**",
5352
"rules": {
54-
"@typescript-eslint/ban-types": "off",
55-
"@typescript-eslint/explicit-module-boundary-types": "off",
5653
"@typescript-eslint/no-explicit-any": "off",
5754
"@typescript-eslint/no-unsafe-assignment": "off",
58-
"@typescript-eslint/no-unsafe-call": "off",
5955
"@typescript-eslint/no-unsafe-member-access": "off",
60-
"@typescript-eslint/no-unsafe-return": "off",
6156
"@typescript-eslint/no-var-requires": "off",
6257
"@typescript-eslint/prefer-regexp-exec": "off",
6358
"@typescript-eslint/require-await": "off",
6459
"@typescript-eslint/restrict-template-expressions": "off",
65-
"func-style": "off",
66-
"sort-imports": "off"
60+
"func-style": "off"
6761
}
6862
}],
6963
"settings": {

lib/analyze-action-post-helper.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/api-client.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/api-client.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/codeql.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/codeql.test.js

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/codeql.test.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/config-utils.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/database-upload.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/database-upload.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)