@@ -33,13 +33,13 @@ test.beforeEach(() => {
33
33
34
34
const testRepositoryNwo = parseRepositoryNwo ( "github/example" ) ;
35
35
36
- test ( `All features are disabled if running against GHES` , async ( t ) => {
36
+ test ( `Return feature defaultValue if running against GHES` , async ( t ) => {
37
37
await withTmpDir ( async ( tmpDir ) => {
38
38
const loggedMessages = [ ] ;
39
39
const features = setUpFeatureFlagTests (
40
40
tmpDir ,
41
41
getRecordingLogger ( loggedMessages ) ,
42
- { type : GitHubVariant . GHES , version : "3 .0.0" } ,
42
+ { type : GitHubVariant . GHES , version : "4 .0.0" } ,
43
43
) ;
44
44
45
45
for ( const feature of Object . values ( Feature ) ) {
@@ -60,6 +60,36 @@ test(`All features are disabled if running against GHES`, async (t) => {
60
60
} ) ;
61
61
} ) ;
62
62
63
+ const DIFF_INFORMED_QUERIES_TEST_CASES = [
64
+ { version : "3.18.0.pre1" , expected : false } ,
65
+ { version : "3.18.5" , expected : false } ,
66
+ { version : "3.19.0.pre1" , expected : true } ,
67
+ { version : "3.19.0.gm1" , expected : true } ,
68
+ { version : "3.19.0.rc1" , expected : true } ,
69
+ { version : "3.19.0" , expected : true } ,
70
+ { version : "3.20.0.pre1" , expected : true } ,
71
+ { version : "3.20.0" , expected : true } ,
72
+ ] ;
73
+
74
+ // Test cases for the minimumGhesVersion field, via Feature.DiffInformedQueries
75
+ for ( const testCase of DIFF_INFORMED_QUERIES_TEST_CASES ) {
76
+ const feature = Feature . DiffInformedQueries ;
77
+ test ( `Feature ${ feature } is ${ testCase . expected ? "enabled" : "disabled" } for GHES ${ testCase . version } ` , async ( t ) => {
78
+ await withTmpDir ( async ( tmpDir ) => {
79
+ const loggedMessages = [ ] ;
80
+ const features = setUpFeatureFlagTests (
81
+ tmpDir ,
82
+ getRecordingLogger ( loggedMessages ) ,
83
+ { type : GitHubVariant . GHES , version : testCase . version } ,
84
+ ) ;
85
+ t . is (
86
+ await features . getValue ( feature , includeCodeQlIfRequired ( feature ) ) ,
87
+ testCase . expected ,
88
+ ) ;
89
+ } ) ;
90
+ } ) ;
91
+ }
92
+
63
93
test ( `Feature flags are requested in Proxima` , async ( t ) => {
64
94
await withTmpDir ( async ( tmpDir ) => {
65
95
const loggedMessages = [ ] ;
0 commit comments