Skip to content

Commit e106171

Browse files
committed
Revert "reintroduce PR check that confirm action can be still be compiled on node16"
This reverts commit 5b52b36.
1 parent 231f9f1 commit e106171

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

.github/workflows/pr-checks.yml

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -15,39 +15,13 @@ jobs:
1515
runs-on: ubuntu-latest
1616
timeout-minutes: 45
1717

18-
strategy:
19-
matrix:
20-
node-types-version: [16.11, current] # run tests on 16.11 while CodeQL Action v2 is still supported
21-
2218
steps:
2319
- name: Checkout
2420
uses: actions/checkout@v4
2521

2622
- name: Lint
2723
run: npm run-script lint
2824

29-
- name: Update version of @types/node
30-
if: matrix.node-types-version != 'current'
31-
env:
32-
NODE_TYPES_VERSION: ${{ matrix.node-types-version }}
33-
run: |
34-
# Export `NODE_TYPES_VERSION` so it's available to jq
35-
export NODE_TYPES_VERSION="${NODE_TYPES_VERSION}"
36-
contents=$(jq '.devDependencies."@types/node" = env.NODE_TYPES_VERSION' package.json)
37-
echo "${contents}" > package.json
38-
# Usually we run `npm install` on macOS to ensure that we pick up macOS-only dependencies.
39-
# However we're not checking in the updated lockfile here, so it's fine to run
40-
# `npm install` on Linux.
41-
npm install
42-
43-
if [ ! -z "$(git status --porcelain)" ]; then
44-
git config --global user.email "[email protected]"
45-
git config --global user.name "github-actions[bot]"
46-
# The period in `git add --all .` ensures that we stage deleted files too.
47-
git add --all .
48-
git commit -m "Use @types/node=${NODE_TYPES_VERSION}"
49-
fi
50-
5125
- name: Check generated JS
5226
run: .github/workflows/script/check-js.sh
5327

0 commit comments

Comments
 (0)