Skip to content

Commit e3f5f83

Browse files
Apply suggestions from code review
Co-authored-by: Henry Mercer <[email protected]>
1 parent 838be48 commit e3f5f83

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

pr-checks/checks/cpp-deptrace-disabled.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
name: "Cpp: disabling autoinstalling dependencies"
1+
name: "C/C++: disabling autoinstalling dependencies (Linux)"
22
description: "Checks that running C/C++ autobuild with autoinstalling dependencies explicitly disabled works"
33
operatingSystems: ["ubuntu"]
4-
versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with old CLIs
4+
versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with CLIs < 2.15.0
55
env:
66
DOTNET_GENERATE_ASPNET_CERTIFICATE: "false"
77
steps:
@@ -21,6 +21,6 @@ steps:
2121
- shell: bash
2222
run: |
2323
if ls /usr/bin/errno; then
24-
echo "Did autoinstall errno, and it should not have"
24+
echo "C/C++ autobuild installed errno, but it should not have since auto-install dependencies is disabled."
2525
exit 1
2626
fi

pr-checks/checks/cpp-deptrace-enabled-on-macos.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
name: "Cpp: disabling autoinstalling dependencies"
2-
description: "Checks that running C/C++ autobuild with autoinstalling dependencies explicitly disabled works"
1+
name: "C/C++: autoinstalling dependencies is skipped (macOS)"
2+
description: "Checks that running C/C++ autobuild with autoinstalling dependencies explicitly enabled is a no-op on macOS"
33
operatingSystems: ["macos"]
44
versions: ["nightly-latest"] # This is not released yet, will come with 2.15.2
55
env:

pr-checks/checks/cpp-deptrace-enabled.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
name: "Cpp: enabling autoinstalling dependencies"
1+
name: "C/C++: autoinstalling dependencies (Linux)"
22
description: "Checks that running C/C++ autobuild with autoinstalling dependencies works"
33
operatingSystems: ["ubuntu"]
4-
versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with old CLIs
4+
versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with CLIs < 2.15.0
55
env:
66
DOTNET_GENERATE_ASPNET_CERTIFICATE: "false"
77
steps:

0 commit comments

Comments
 (0)