Skip to content

Commit e4ef094

Browse files
authored
Merge branch 'main' into henrymercer/deprecate-codeql-2.9
2 parents 219066c + 2cc1651 commit e4ef094

File tree

6 files changed

+20
-3
lines changed

6 files changed

+20
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th
55
## [UNRELEASED]
66

77
- The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. [#1907](https://github.com/github/codeql-action/pull/1907)
8+
9+
## 2.21.9 - 27 Sep 2023
10+
811
- Update default CodeQL bundle version to 2.14.6. [#1897](https://github.com/github/codeql-action/pull/1897)
912
- We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. [#1889](https://github.com/github/codeql-action/pull/1889)
1013
- We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. [#1903](https://github.com/github/codeql-action/pull/1903)

lib/api-compatibility.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ "maximumVersion": "3.11", "minimumVersion": "3.6" }
1+
{ "maximumVersion": "3.11", "minimumVersion": "3.7" }

lib/util.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/util.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/api-compatibility.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"maximumVersion": "3.11", "minimumVersion": "3.6"}
1+
{"maximumVersion": "3.11", "minimumVersion": "3.7"}

src/util.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ function getCgroupMemoryLimitBytes(
260260
}
261261

262262
const limit = Number(fs.readFileSync(limitFile, "utf8"));
263+
263264
if (!Number.isInteger(limit)) {
264265
logger.debug(
265266
`While resolving RAM, ignored the file ${limitFile} that may contain a cgroup memory limit ` +
@@ -269,6 +270,14 @@ function getCgroupMemoryLimitBytes(
269270
}
270271

271272
const displayLimit = `${Math.floor(limit / (1024 * 1024))} MiB`;
273+
if (limit > os.totalmem()) {
274+
logger.debug(
275+
`While resolving RAM, ignored the file ${limitFile} that may contain a cgroup memory limit as ` +
276+
`its contents ${displayLimit} were greater than the total amount of system memory.`,
277+
);
278+
return undefined;
279+
}
280+
272281
if (limit < MINIMUM_CGROUP_MEMORY_LIMIT_BYTES) {
273282
logger.info(
274283
`While resolving RAM, ignored a cgroup limit of ${displayLimit} in ${limitFile} as it was below ${

0 commit comments

Comments
 (0)