Merge pull request #2382 from github/angelapwen/make-autobuild-config-error

Classify autobuild errors as configuration errors

Author: angelapwen

lib/cli-errors.js

@@ -122,6 +122,7 @@ function ensureEndsInPeriod(text: string): string {
 
 /** Error messages from the CLI that we consider configuration errors and handle specially. */
 export enum CliConfigErrorCategory {
+  AutobuildError = "AutobuildError",
   ExternalRepositoryCloneFailed = "ExternalRepositoryCloneFailed",
   GradleBuildFailed = "GradleBuildFailed",
   IncompatibleWithActionVersion = "IncompatibleWithActionVersion",
@@ -156,6 +157,11 @@ export const cliErrorsConfig: Record<
   CliConfigErrorCategory,
   CliErrorConfiguration
 > = {
+  [CliConfigErrorCategory.AutobuildError]: {
+    cliErrorMessageCandidates: [
+      new RegExp("We were unable to automatically build your code"),
+    ],
+  },
   [CliConfigErrorCategory.ExternalRepositoryCloneFailed]: {
     cliErrorMessageCandidates: [
       new RegExp("Failed to clone external Git repository"),

lib/cli-errors.js.map

@@ -906,7 +906,7 @@ test("runTool summarizes autobuilder errors", async (t) => {
   await t.throwsAsync(
     async () => await codeqlObject.runAutobuild(stubConfig, Language.java),
     {
-      instanceOf: CommandInvocationError,
+      instanceOf: util.ConfigurationError,
       message:
         "We were unable to automatically build your code. Please provide manual build steps. " +
         "For more information, see " +
@@ -934,7 +934,7 @@ test("runTool truncates long autobuilder errors", async (t) => {
   await t.throwsAsync(
     async () => await codeqlObject.runAutobuild(stubConfig, Language.java),
     {
-      instanceOf: CommandInvocationError,
+      instanceOf: util.ConfigurationError,
       message:
         "We were unable to automatically build your code. Please provide manual build steps. " +
         "For more information, see " +