Implement INT36-C

Author: jeongsoolee09

c/cert/src/rules/INT36-C/ConvertingAPointerToIntegerOrIntegerToPointer.ql

@@ -13,26 +13,87 @@
 import cpp
 import codingstandards.c.cert
 
-/* 1. Declaring an integer variable to hold a pointer value */
-predicate integerVariableWithPointerValue(Variable var) {
-  var.getUnderlyingType() instanceof IntType and
-  var.getAnAssignedValue().getUnderlyingType() instanceof PointerType
+class LiteralZero extends Literal {
+  LiteralZero() { this.getValue() = "0" }
 }
 
-/* 2. Assigning an integer variable a pointer a pointer value */
-predicate assigningPointerValueToInteger(Assignment assign) {
-  assign.getLValue().getUnderlyingType() instanceof IntType and
-  assign.getRValue().getUnderlyingType() instanceof PointerType
+class StdIntIntPtrType extends IntPointerType {
+  StdIntIntPtrType() {
+    this.getFile().(HeaderFile).getBaseName() = "stdint.h" and
+    this.getName().regexpMatch("u?intptr_t")
+  }
 }
 
-/* 3. Casting a pointer value to integer */
-predicate castingPointerToInteger(Cast cast) {
-  cast.getExpr().getUnderlyingType() instanceof PointerType and
-  cast.getUnderlyingType() instanceof PointerType
+/* 1. Declaring an integer variable to hold a pointer value or the opposite, excluding compliant exceptions */
+predicate integerVariableWithPointerValue(Variable var, string message) {
+  (
+    // Declaring an integer variable to hold a pointer value
+    var.getUnderlyingType() instanceof IntType and
+    var.getAnAssignedValue().getUnderlyingType() instanceof PointerType and
+    message =
+      "Integer variable " + var + " is declared as an expression " + var.getAnAssignedValue() +
+        ", which is of a pointer type."
+    or
+    // Declaring an pointer variable to hold a integer value
+    var.getUnderlyingType() instanceof PointerType and
+    var.getAnAssignedValue().getUnderlyingType() instanceof IntType and
+    message =
+      "Pointer variable " + var + " is declared as an expression " + var.getAnAssignedValue() +
+        ", which is of integer type."
+  ) and
+  /* Compliant exception 1: literal 0 */
+  not var.getAnAssignedValue() instanceof LiteralZero and
+  /* Compliant exception 2: variable's declared type is (u)intptr_t */
+  not var.getUnderlyingType() instanceof StdIntIntPtrType
 }
 
-from Variable x
+/* 2. Assigning an integer variable a pointer a pointer value, excluding literal 0 */
+predicate assigningPointerValueToInteger(Assignment assign, string message) {
+  (
+    assign.getLValue().getUnderlyingType() instanceof IntType and
+    assign.getRValue().getUnderlyingType() instanceof PointerType and
+    message =
+      "Integer variable " + assign.getLValue() + " is assigned an expression " + assign.getRValue() +
+        ", which is of a pointer type."
+    or
+    assign.getLValue().getUnderlyingType() instanceof PointerType and
+    assign.getRValue().getUnderlyingType() instanceof IntType and
+    message =
+      "Pointer variable " + assign.getLValue() + " is assigned an expression " + assign.getRValue() +
+        ", which is of integer type."
+  ) and
+  /* Compliant exception 1: literal 0 */
+  not assign.getRValue() instanceof LiteralZero and
+  /* Compliant exception 2: variable's declared type is (u)intptr_t */
+  not assign.getLValue().getUnderlyingType() instanceof StdIntIntPtrType
+}
+
+/* 3. Casting a pointer value to integer, excluding literal 0 */
+predicate castingPointerToInteger(Cast cast, string message) {
+  not cast.isCompilerGenerated() and
+  (
+    cast.getExpr().getUnderlyingType() instanceof IntType and
+    cast.getUnderlyingType() instanceof PointerType and
+    message = "Integer expression " + cast.getExpr() + " is cast to a pointer type."
+    or
+    cast.getExpr().getUnderlyingType() instanceof PointerType and
+    cast.getUnderlyingType() instanceof IntType and
+    message = "Pointer expression " + cast.getExpr() + " is cast to integer type."
+  ) and
+  /* Compliant exception 1: literal 0 */
+  not cast.getExpr() instanceof LiteralZero and
+  /* Compliant exception 2: variable's declared type is (u)intptr_t */
+  not cast.getUnderlyingType() instanceof StdIntIntPtrType
+}
+
+from Element elem, string message
 where
-  not isExcluded(x, TypesPackage::convertingAPointerToIntegerOrIntegerToPointerQuery()) and
-  x.getType() instanceof PointerType
-select x, x.getType().getAPrimaryQlClass()
+  not isExcluded(elem, TypesPackage::convertingAPointerToIntegerOrIntegerToPointerQuery()) and
+  (
+    integerVariableWithPointerValue(elem, message)
+    or
+    assigningPointerValueToInteger(elem, message)
+    or
+    castingPointerToInteger(elem, message)
+  )
+select elem, message

c/cert/test/rules/INT36-C/ConvertingAPointerToIntegerOrIntegerToPointer.expected

@@ -1 +1,11 @@
-No expected results have yet been specified
+| test.c:17:8:17:19 | int_pointer3 | Pointer variable int_pointer3 is declared as an expression 28036591, which is of integer type. |
+| test.c:19:3:20:16 | ... = ... | Pointer variable int_pointer3 is assigned an expression 28036591, which is of integer type. |
+| test.c:21:8:21:19 | int_pointer4 | Pointer variable int_pointer4 is declared as an expression integer1, which is of integer type. |
+| test.c:26:8:26:23 | integer_address5 | Pointer variable integer_address5 is declared as an expression 28036591, which is of integer type. |
+| test.c:27:7:27:23 | (int *)... | Integer expression 28036591 is cast to a pointer type. |
+| test.c:28:8:28:23 | integer_address6 | Pointer variable integer_address6 is declared as an expression integer1, which is of integer type. |
+| test.c:29:7:29:21 | (int *)... | Integer expression integer1 is cast to a pointer type. |
+| test.c:34:7:34:22 | integer_address8 | Integer variable integer_address8 is declared as an expression & ..., which is of a pointer type. |
+| test.c:36:3:36:30 | ... = ... | Integer variable integer_address8 is assigned an expression & ..., which is of a pointer type. |
+| test.c:38:7:38:21 | integer_address | Integer variable integer_address is declared as an expression & ..., which is of a pointer type. |
+| test.c:39:7:39:20 | (int)... | Pointer expression & ... is cast to integer type. |