Convert MSC51-CPP to the new dataflow library

jketema · jketema · commit 3289621c7375 · 2025-07-07T15:07:39.000+02:00
diff --git a/cpp/cert/src/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.ql b/cpp/cert/src/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.ql
@@ -20,7 +20,7 @@
 import cpp
 import codingstandards.cpp.cert
 import codingstandards.cpp.standardlibrary.Random
-import semmle.code.cpp.dataflow.TaintTracking
+import semmle.code.cpp.dataflow.new.TaintTracking
 
 from RandomNumberEngineCreation createRandomNumberEngine, string seedSource
 where
diff --git a/cpp/cert/test/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.expected b/cpp/cert/test/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.expected
@@ -1,4 +1,3 @@
-WARNING: module 'TaintTracking' has been deprecated and may be removed in future (BadlySeededRandomNumberGenerator.ql:42,7-20)
 | test.cpp:9:33:9:33 | call to linear_congruential_engine | Random number generator linear_congruential_engine is default-initialized and is therefore not properly seeded. |
 | test.cpp:10:30:10:31 | call to linear_congruential_engine | Random number generator linear_congruential_engine is default-initialized and is therefore not properly seeded. |
 | test.cpp:11:21:11:22 | call to linear_congruential_engine | Random number generator linear_congruential_engine is default-initialized and is therefore not properly seeded. |

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-WARNING: module 'TaintTracking' has been deprecated and may be removed in future (BadlySeededRandomNumberGenerator.ql:42,7-20)`
`2`	`1`	`\| test.cpp:9:33:9:33 \| call to linear_congruential_engine \| Random number generator linear_congruential_engine is default-initialized and is therefore not properly seeded. \|`
`3`	`2`	`\| test.cpp:10:30:10:31 \| call to linear_congruential_engine \| Random number generator linear_congruential_engine is default-initialized and is therefore not properly seeded. \|`
`4`	`3`	`\| test.cpp:11:21:11:22 \| call to linear_congruential_engine \| Random number generator linear_congruential_engine is default-initialized and is therefore not properly seeded. \|`