tests

Author: jsinglet

c/common/test/rules/donotallowamutextogooutofscopewhilelocked/DoNotAllowAMutexToGoOutOfScopeWhileLocked.expected

@@ -0,0 +1,2 @@
+| test.c:43:3:43:10 | call to mtx_init | Mutex used by thread potentially destroyed while in use. |
+| test.c:58:3:58:10 | call to mtx_init | Mutex used by thread potentially destroyed while in use. |

c/common/test/rules/donotallowamutextogooutofscopewhilelocked/DoNotAllowAMutexToGoOutOfScopeWhileLocked.ql

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.donotallowamutextogooutofscopewhilelocked.DoNotAllowAMutexToGoOutOfScopeWhileLocked

c/common/test/rules/donotallowamutextogooutofscopewhilelocked/test.c

@@ -0,0 +1,83 @@
+#include <stddef.h>
+#include <threads.h>
+
+int t3(void *data) {
+  mtx_t *mxl = (mtx_t *)data;
+  mtx_lock(mxl);
+  mtx_unlock(mxl);
+  return 0;
+}
+
+int t4(void *data) {
+  mtx_t *mxl = (mtx_t *)data;
+  mtx_lock(mxl);
+  mtx_unlock(mxl);
+  return 0;
+}
+
+// case 3 - correctly waiting for a well-behaved thread, with a local mutex.
+int f3() {
+  thrd_t threads[5];
+
+  mtx_t mxl;
+
+  mtx_init(&mxl, mtx_plain); // COMPLIANT
+
+  for (size_t i = 0; i < 1; i++) {
+    thrd_create(&threads[i], t3, &mxl);
+  }
+
+  for (size_t i = 0; i < 1; i++) {
+    thrd_join(threads[i], 0);
+  }
+
+  mtx_destroy(&mxl);
+  return 0;
+}
+
+// case 4 - incorrectly waiting for a well behaved thread, with a local mutex.
+int f4() {
+  thrd_t threads[5];
+  mtx_t mxl;
+
+  mtx_init(&mxl, mtx_plain); // NON_COMPLIANT
+
+  for (size_t i = 0; i < 1; i++) {
+    thrd_create(&threads[i], t3, &mxl);
+  }
+
+  mtx_destroy(&mxl);
+  return 0;
+}
+
+// case 5 - incorrectly waiting with a stack local variable.
+int f5() {
+  thrd_t threads[5];
+  mtx_t mxl;
+
+  mtx_init(&mxl, mtx_plain); // NON_COMPLIANT
+
+  for (size_t i = 0; i < 1; i++) {
+    thrd_create(&threads[i], t4, &mxl);
+  }
+
+  return 0;
+}
+
+// case 6 - correctly waiting with a stack local variable.
+int f6() {
+  thrd_t threads[5];
+  mtx_t mxl;
+
+  mtx_init(&mxl, mtx_plain); // COMPLIANT
+
+  for (size_t i = 0; i < 1; i++) {
+    thrd_create(&threads[i], t4, &mxl);
+  }
+
+  for (size_t i = 0; i < 1; i++) {
+    thrd_join(threads[i], 0);
+  }
+
+  return 0;
+}

c/common/test/rules/donotdestroyamutexwhileitislocked/DoNotDestroyAMutexWhileItIsLocked.expected

@@ -0,0 +1,2 @@
+| test.c:49:3:49:10 | call to mtx_init | Mutex used by thread potentially $@ while in use. | test.c:55:3:55:13 | call to mtx_destroy | destroyed |
+| test.c:84:3:84:10 | call to mtx_init | Mutex used by thread potentially $@ while in use. | test.c:90:3:90:13 | call to mtx_destroy | destroyed |

c/common/test/rules/donotdestroyamutexwhileitislocked/DoNotDestroyAMutexWhileItIsLocked.ql

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.donotdestroyamutexwhileitislocked.DoNotDestroyAMutexWhileItIsLocked

cpp/cert/test/rules/CON50-CPP/test.c renamed to c/common/test/rules/donotdestroyamutexwhileitislocked/test.c

@@ -1,4 +1,3 @@
-#include <stdatomic.h>
 #include <stddef.h>
 #include <threads.h>
 
@@ -26,13 +25,6 @@ int t3(void *data) {
   return 0;
 }
 
-int t4(void *data) {
-  mtx_t *mxl = (mtx_t *)data;
-  mtx_lock(mxl);
-  mtx_unlock(mxl);
-  return 0;
-}
-
 // case 1 - correctly waiting for a well-behaved thread
 int f1() {
   thrd_t threads[5];
@@ -98,35 +90,3 @@ int f4() {
   mtx_destroy(&mxl);
   return 0;
 }
-
-// case 5 - incorrectly waiting with a stack local variable.
-int f5() {
-  thrd_t threads[5];
-  mtx_t mxl;
-
-  mtx_init(&mxl, mtx_plain); // NON_COMPLIANT
-
-  for (size_t i = 0; i < 1; i++) {
-    thrd_create(&threads[i], t4, &mxl);
-  }
-
-  return 0;
-}
-
-// case 6 - correctly waiting with a stack local variable.
-int f6() {
-  thrd_t threads[5];
-  mtx_t mxl;
-
-  mtx_init(&mxl, mtx_plain); // COMPLIANT
-
-  for (size_t i = 0; i < 1; i++) {
-    thrd_create(&threads[i], t4, &mxl);
-  }
-
-  for (size_t i = 0; i < 1; i++) {
-    thrd_join(threads[i], 0);
-  }
-
-  return 0;
-}