Merge pull request #359 from smowton/smowton/fix/suspicious-regex-qhelp

Improve variable names in example code

Author: smowton

ql/src/Security/CWE-020/SuspiciousCharacterInRegexp.go

@@ -3,8 +3,8 @@ package main
 import "regexp"
 
 func broken(hostNames []byte) string {
-	var htmlRe = regexp.MustCompile("\bforbidden.host.org")
-	if htmlRe.Match(hostNames) {
+	var hostRe = regexp.MustCompile("\bforbidden.host.org")
+	if hostRe.Match(hostNames) {
 		return "Must not target forbidden.host.org"
 	} else {
 		// This will be reached even if hostNames is exactly "forbidden.host.org",

ql/src/Security/CWE-020/SuspiciousCharacterInRegexpGood.go

@@ -3,8 +3,8 @@ package main
 import "regexp"
 
 func fixed(hostNames []byte) string {
-	var htmlRe = regexp.MustCompile("\\bforbidden.host.org")
-	if htmlRe.Match(hostNames) {
+	var hostRe = regexp.MustCompile("\\bforbidden.host.org")
+	if hostRe.Match(hostNames) {
 		return "Must not target forbidden.host.org"
 	} else {
 		// hostNames definitely doesn't contain a word "forbidden.host.org", as "\\b"