Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Commit 314bda2

Browse files
author
Max Schaefer
committed
Fix compiler errors in tests.
1 parent 79b0ea8 commit 314bda2

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

‎ql/test/query-tests/Security/CWE-079/ReflectedXss.expected

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ edges
22
| ReflectedXss.go:11:15:11:20 | selection of Form : Values | ReflectedXss.go:14:44:14:51 | username |
33
| contenttype.go:11:11:11:16 | selection of Form : Values | contenttype.go:17:11:17:22 | type conversion |
44
| contenttype.go:49:11:49:16 | selection of Form : Values | contenttype.go:53:34:53:37 | data |
5-
| contenttype.go:63:11:63:29 | call to FormValue : string | contenttype.go:64:52:64:55 | data |
6-
| contenttype.go:73:11:73:29 | call to FormValue : string | contenttype.go:79:11:79:14 | data |
7-
| contenttype.go:88:11:88:29 | call to FormValue : string | contenttype.go:91:4:91:7 | data |
8-
| contenttype.go:113:11:113:29 | call to FormValue : string | contenttype.go:114:50:114:53 | data |
5+
| contenttype.go:63:10:63:28 | call to FormValue : string | contenttype.go:64:52:64:55 | data |
6+
| contenttype.go:73:10:73:28 | call to FormValue : string | contenttype.go:79:11:79:14 | data |
7+
| contenttype.go:88:10:88:28 | call to FormValue : string | contenttype.go:91:4:91:7 | data |
8+
| contenttype.go:113:10:113:28 | call to FormValue : string | contenttype.go:114:50:114:53 | data |
99
| tst.go:14:15:14:20 | selection of Form : Values | tst.go:18:12:18:39 | type conversion |
1010
| tst.go:48:14:48:19 | selection of Form : Values | tst.go:53:12:53:26 | type conversion |
1111
| websocketXss.go:30:7:30:10 | definition of xnet : slice type | websocketXss.go:32:24:32:27 | xnet |
@@ -21,13 +21,13 @@ nodes
2121
| contenttype.go:17:11:17:22 | type conversion | semmle.label | type conversion |
2222
| contenttype.go:49:11:49:16 | selection of Form : Values | semmle.label | selection of Form : Values |
2323
| contenttype.go:53:34:53:37 | data | semmle.label | data |
24-
| contenttype.go:63:11:63:29 | call to FormValue : string | semmle.label | call to FormValue : string |
24+
| contenttype.go:63:10:63:28 | call to FormValue : string | semmle.label | call to FormValue : string |
2525
| contenttype.go:64:52:64:55 | data | semmle.label | data |
26-
| contenttype.go:73:11:73:29 | call to FormValue : string | semmle.label | call to FormValue : string |
26+
| contenttype.go:73:10:73:28 | call to FormValue : string | semmle.label | call to FormValue : string |
2727
| contenttype.go:79:11:79:14 | data | semmle.label | data |
28-
| contenttype.go:88:11:88:29 | call to FormValue : string | semmle.label | call to FormValue : string |
28+
| contenttype.go:88:10:88:28 | call to FormValue : string | semmle.label | call to FormValue : string |
2929
| contenttype.go:91:4:91:7 | data | semmle.label | data |
30-
| contenttype.go:113:11:113:29 | call to FormValue : string | semmle.label | call to FormValue : string |
30+
| contenttype.go:113:10:113:28 | call to FormValue : string | semmle.label | call to FormValue : string |
3131
| contenttype.go:114:50:114:53 | data | semmle.label | data |
3232
| tst.go:14:15:14:20 | selection of Form : Values | semmle.label | selection of Form : Values |
3333
| tst.go:18:12:18:39 | type conversion | semmle.label | type conversion |
@@ -49,10 +49,10 @@ nodes
4949
| ReflectedXss.go:14:44:14:51 | username | ReflectedXss.go:11:15:11:20 | selection of Form : Values | ReflectedXss.go:14:44:14:51 | username | Cross-site scripting vulnerability due to $@. | ReflectedXss.go:11:15:11:20 | selection of Form | user-provided value |
5050
| contenttype.go:17:11:17:22 | type conversion | contenttype.go:11:11:11:16 | selection of Form : Values | contenttype.go:17:11:17:22 | type conversion | Cross-site scripting vulnerability due to $@. | contenttype.go:11:11:11:16 | selection of Form | user-provided value |
5151
| contenttype.go:53:34:53:37 | data | contenttype.go:49:11:49:16 | selection of Form : Values | contenttype.go:53:34:53:37 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:49:11:49:16 | selection of Form | user-provided value |
52-
| contenttype.go:64:52:64:55 | data | contenttype.go:63:11:63:29 | call to FormValue : string | contenttype.go:64:52:64:55 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:63:11:63:29 | call to FormValue | user-provided value |
53-
| contenttype.go:79:11:79:14 | data | contenttype.go:73:11:73:29 | call to FormValue : string | contenttype.go:79:11:79:14 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:73:11:73:29 | call to FormValue | user-provided value |
54-
| contenttype.go:91:4:91:7 | data | contenttype.go:88:11:88:29 | call to FormValue : string | contenttype.go:91:4:91:7 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:88:11:88:29 | call to FormValue | user-provided value |
55-
| contenttype.go:114:50:114:53 | data | contenttype.go:113:11:113:29 | call to FormValue : string | contenttype.go:114:50:114:53 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:113:11:113:29 | call to FormValue | user-provided value |
52+
| contenttype.go:64:52:64:55 | data | contenttype.go:63:10:63:28 | call to FormValue : string | contenttype.go:64:52:64:55 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:63:10:63:28 | call to FormValue | user-provided value |
53+
| contenttype.go:79:11:79:14 | data | contenttype.go:73:10:73:28 | call to FormValue : string | contenttype.go:79:11:79:14 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:73:10:73:28 | call to FormValue | user-provided value |
54+
| contenttype.go:91:4:91:7 | data | contenttype.go:88:10:88:28 | call to FormValue : string | contenttype.go:91:4:91:7 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:88:10:88:28 | call to FormValue | user-provided value |
55+
| contenttype.go:114:50:114:53 | data | contenttype.go:113:10:113:28 | call to FormValue : string | contenttype.go:114:50:114:53 | data | Cross-site scripting vulnerability due to $@. | contenttype.go:113:10:113:28 | call to FormValue | user-provided value |
5656
| tst.go:18:12:18:39 | type conversion | tst.go:14:15:14:20 | selection of Form : Values | tst.go:18:12:18:39 | type conversion | Cross-site scripting vulnerability due to $@. | tst.go:14:15:14:20 | selection of Form | user-provided value |
5757
| tst.go:53:12:53:26 | type conversion | tst.go:48:14:48:19 | selection of Form : Values | tst.go:53:12:53:26 | type conversion | Cross-site scripting vulnerability due to $@. | tst.go:48:14:48:19 | selection of Form | user-provided value |
5858
| websocketXss.go:32:24:32:27 | xnet | websocketXss.go:30:7:30:10 | definition of xnet : slice type | websocketXss.go:32:24:32:27 | xnet | Cross-site scripting vulnerability due to $@. | websocketXss.go:30:7:30:10 | definition of xnet | user-provided value |

‎ql/test/query-tests/Security/CWE-079/contenttype.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func serve10() {
6060
r.ParseForm()
6161
data := r.Form.Get("data")
6262

63-
data := r.FormValue("data")
63+
data = r.FormValue("data")
6464
fmt.Fprintf(w, "\t<html><body>%s</body></html>", data) // Not OK
6565
})
6666
}
@@ -70,7 +70,7 @@ func serve11() {
7070
r.ParseForm()
7171
data := r.Form.Get("data")
7272

73-
data := r.FormValue("data")
73+
data = r.FormValue("data")
7474
fmt.Fprintf(w, `
7575
<html>
7676
<body>
@@ -85,7 +85,7 @@ func serve12() {
8585
r.ParseForm()
8686
data := r.Form.Get("data")
8787

88-
data := r.FormValue("data")
88+
data = r.FormValue("data")
8989
fmt.Fprintf(w, `
9090
%s
9191
`, data) // Not OK
@@ -97,7 +97,7 @@ func serve13() {
9797
r.ParseForm()
9898
data := r.Form.Get("data")
9999

100-
data := r.FormValue("data")
100+
data = r.FormValue("data")
101101
fmt.Fprintf(w, `
102102
Echoed:
103103
%s
@@ -110,7 +110,7 @@ func serve14() {
110110
r.ParseForm()
111111
data := r.Form.Get("data")
112112

113-
data := r.FormValue("data")
113+
data = r.FormValue("data")
114114
fmt.Fprintf(w, "<html><body>%s</body></html>", data) // Not OK
115115
})
116116
}

0 commit comments

Comments
 (0)