Insecure-TLS: remove obsolete TODO

smowton · smowton · commit 3c244e223542 · 2020-07-28T13:04:16.000+01:00
The case noted works fine.
diff --git a/ql/src/experimental/CWE-327/InsecureTLS.ql b/ql/src/experimental/CWE-327/InsecureTLS.ql
@@ -185,7 +185,6 @@ class TlsInsecureCipherSuitesFlowConfig extends TaintTracking::Configuration {
   }
 
   override predicate isSource(DataFlow::Node source) {
-    // TODO: source can also be result of tls.InsecureCipherSuites()[0].ID
     isSourceInsecureCipherSuites(source)
     or
     isSourceValueEntity(source, _)

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,6 @@ class TlsInsecureCipherSuitesFlowConfig extends TaintTracking::Configuration {`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`override predicate isSource(DataFlow::Node source) {`
`188`		`- // TODO: source can also be result of tls.InsecureCipherSuites()[0].ID`
`189`	`188`	`isSourceInsecureCipherSuites(source)`
`190`	`189`	`or`
`191`	`190`	`isSourceValueEntity(source, _)`