Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Commit 57518c7

Browse files
committed
Add taint-tracking for encoding/csv
1 parent df55bb4 commit 57518c7

File tree

3 files changed

+136
-0
lines changed

3 files changed

+136
-0
lines changed

ql/src/semmle/go/frameworks/Stdlib.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import semmle.go.frameworks.stdlib.EncodingAsn1
2121
import semmle.go.frameworks.stdlib.EncodingBase32
2222
import semmle.go.frameworks.stdlib.EncodingBase64
2323
import semmle.go.frameworks.stdlib.EncodingBinary
24+
import semmle.go.frameworks.stdlib.EncodingCsv
2425
import semmle.go.frameworks.stdlib.Path
2526
import semmle.go.frameworks.stdlib.PathFilepath
2627
import semmle.go.frameworks.stdlib.Reflect
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
/**
2+
* Provides classes modeling security-relevant aspects of the `encoding/csv` package.
3+
*/
4+
5+
import go
6+
7+
/** Provides models of commonly used functions in the `encoding/csv` package. */
8+
module EncodingCsv {
9+
private class FunctionModels extends TaintTracking::FunctionModel {
10+
FunctionInput inp;
11+
FunctionOutput outp;
12+
13+
FunctionModels() {
14+
// signature: func NewReader(r io.Reader) *Reader
15+
hasQualifiedName("encoding/csv", "NewReader") and
16+
(inp.isParameter(0) and outp.isResult())
17+
or
18+
// signature: func NewWriter(w io.Writer) *Writer
19+
hasQualifiedName("encoding/csv", "NewWriter") and
20+
(inp.isResult() and outp.isParameter(0))
21+
}
22+
23+
override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
24+
input = inp and output = outp
25+
}
26+
}
27+
28+
private class MethodModels extends TaintTracking::FunctionModel, Method {
29+
FunctionInput inp;
30+
FunctionOutput outp;
31+
32+
MethodModels() {
33+
// signature: func (*Reader).Read() (record []string, err error)
34+
this.hasQualifiedName("encoding/csv", "Reader", "Read") and
35+
(inp.isReceiver() and outp.isResult(0))
36+
or
37+
// signature: func (*Reader).ReadAll() (records [][]string, err error)
38+
this.hasQualifiedName("encoding/csv", "Reader", "ReadAll") and
39+
(inp.isReceiver() and outp.isResult(0))
40+
or
41+
// signature: func (*Writer).Write(record []string) error
42+
this.hasQualifiedName("encoding/csv", "Writer", "Write") and
43+
(inp.isParameter(0) and outp.isReceiver())
44+
or
45+
// signature: func (*Writer).WriteAll(records [][]string) error
46+
this.hasQualifiedName("encoding/csv", "Writer", "WriteAll") and
47+
(inp.isParameter(0) and outp.isReceiver())
48+
}
49+
50+
override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
51+
input = inp and output = outp
52+
}
53+
}
54+
}

ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/EncodingCsv.go

Lines changed: 81 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)