Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Commit 86ed037

Browse files
committed
Port codeql#4238 (Dataflow: small fixes for naming in taint tracking) to Go's local copy of the dataflow libs
1 parent 362d210 commit 86ed037

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

ql/src/semmle/go/dataflow/internal/TaintTrackingUtil.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ predicate defaultAdditionalTaintStep(DataFlow::Node src, DataFlow::Node sink) {
168168
}
169169

170170
/**
171-
* Holds if `node` should be a barrier in all global taint flow configurations
171+
* Holds if `node` should be a sanitizer in all global taint flow configurations
172172
* but not in local taint.
173173
*/
174-
predicate defaultTaintBarrier(DataFlow::Node node) { none() }
174+
predicate defaultTaintSanitizer(DataFlow::Node node) { none() }

ql/src/semmle/go/dataflow/internal/tainttracking1/TaintTrackingImpl.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,20 +76,20 @@ abstract class Configuration extends DataFlow::Configuration {
7676

7777
final override predicate isBarrier(DataFlow::Node node) {
7878
isSanitizer(node) or
79-
defaultTaintBarrier(node)
79+
defaultTaintSanitizer(node)
8080
}
8181

82-
/** Holds if data flow into `node` is prohibited. */
82+
/** Holds if taint propagation into `node` is prohibited. */
8383
predicate isSanitizerIn(DataFlow::Node node) { none() }
8484

8585
final override predicate isBarrierIn(DataFlow::Node node) { isSanitizerIn(node) }
8686

87-
/** Holds if data flow out of `node` is prohibited. */
87+
/** Holds if taint propagation out of `node` is prohibited. */
8888
predicate isSanitizerOut(DataFlow::Node node) { none() }
8989

9090
final override predicate isBarrierOut(DataFlow::Node node) { isSanitizerOut(node) }
9191

92-
/** Holds if data flow through nodes guarded by `guard` is prohibited. */
92+
/** Holds if taint propagation through nodes guarded by `guard` is prohibited. */
9393
predicate isSanitizerGuard(DataFlow::BarrierGuard guard) { none() }
9494

9595
final override predicate isBarrierGuard(DataFlow::BarrierGuard guard) { isSanitizerGuard(guard) }

0 commit comments

Comments
 (0)