Do not call EmitNewerGoVersionNeeded for v1.21+

mbg · mbg · commit 01a1d814f436 · 2023-10-06T11:57:37.000+01:00
diff --git a/go/extractor/cli/go-autobuilder/go-autobuilder.go b/go/extractor/cli/go-autobuilder/go-autobuilder.go
@@ -788,7 +788,9 @@ func installDependenciesAndBuild() {
 
 	goVersionInfo := tryReadGoDirective(buildInfo)
 
-	if goVersionInfo.Found && semver.Compare("v"+goVersionInfo.Version, getEnvGoSemVer()) > 0 {
+	// This diagnostic is not required if the system Go version is 1.21 or greater, since the
+	// Go tooling should install required Go versions as needed.
+	if semver.Compare(getEnvGoSemVer(), "v1.21.0") < 0 && goVersionInfo.Found && semver.Compare("v"+goVersionInfo.Version, getEnvGoSemVer()) > 0 {
 		diagnostics.EmitNewerGoVersionNeeded()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -788,7 +788,9 @@ func installDependenciesAndBuild() {`
`788`	`788`
`789`	`789`	`goVersionInfo := tryReadGoDirective(buildInfo)`
`790`	`790`
`791`		`- if goVersionInfo.Found && semver.Compare("v"+goVersionInfo.Version, getEnvGoSemVer()) > 0 {`
	`791`	`+ // This diagnostic is not required if the system Go version is 1.21 or greater, since the`
	`792`	`+ // Go tooling should install required Go versions as needed.`
	`793`	`+ if semver.Compare(getEnvGoSemVer(), "v1.21.0") < 0 && goVersionInfo.Found && semver.Compare("v"+goVersionInfo.Version, getEnvGoSemVer()) > 0 {`
`792`	`794`	`diagnostics.EmitNewerGoVersionNeeded()`
`793`	`795`	`}`
`794`	`796`