Merge pull request #20150 from geoffw0/ctorinit

geoffw0 · web-flow · commit 04014d9bf0d1 · 2025-08-11T09:41:16.000+01:00
Rust: Update BadCtorInitialization.ql to use getCanonicalPath.
diff --git a/rust/ql/src/queries/security/CWE-696/BadCtorInitialization.ql b/rust/ql/src/queries/security/CWE-696/BadCtorInitialization.ql
@@ -32,8 +32,7 @@ class CtorAttr extends Attr {
  */
 class StdCall extends Expr {
   StdCall() {
-    this.(CallExpr).getFunction().(PathExpr).getResolvedCrateOrigin() = "lang:std" or
-    this.(MethodCallExpr).getResolvedCrateOrigin() = "lang:std"
+    this.(CallExprBase).getStaticTarget().getCanonicalPath().matches(["std::%", "<std::%"])
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,7 @@ class CtorAttr extends Attr {`
`32`	`32`	`*/`
`33`	`33`	`class StdCall extends Expr {`
`34`	`34`	`StdCall() {`
`35`		`- this.(CallExpr).getFunction().(PathExpr).getResolvedCrateOrigin() = "lang:std" or`
`36`		`- this.(MethodCallExpr).getResolvedCrateOrigin() = "lang:std"`
	`35`	`+ this.(CallExprBase).getStaticTarget().getCanonicalPath().matches(["std::%", "<std::%"])`
`37`	`36`	`}`
`38`	`37`	`}`
`39`	`38`