Add some tests for java/unused-reference-type

owen-mc · owen-mc · commit 050dcb1370e9 · 2024-07-30T16:29:11.000+01:00
diff --git a/java/ql/test/query-tests/DeadCode/DeadRefTypes/ClassWithAnnotatedMethod.java b/java/ql/test/query-tests/DeadCode/DeadRefTypes/ClassWithAnnotatedMethod.java
@@ -0,0 +1,4 @@
+class ClassWithAnnotatedMethod {
+    @MyAnnotation
+    void doNothing() { }
+}
diff --git a/java/ql/test/query-tests/DeadCode/DeadRefTypes/ClassWithAnnotation.java b/java/ql/test/query-tests/DeadCode/DeadRefTypes/ClassWithAnnotation.java
@@ -0,0 +1,3 @@
+@MyAnnotation
+class ClassWithAnnotation {
+}
diff --git a/java/ql/test/query-tests/DeadCode/DeadRefTypes/DeadRefTypes.expected b/java/ql/test/query-tests/DeadCode/DeadRefTypes/DeadRefTypes.expected
@@ -0,0 +1,2 @@
+| ClassWithAnnotatedMethod.java:1:7:1:30 | ClassWithAnnotatedMethod | Unused class: ClassWithAnnotatedMethod is not referenced within this codebase. If not used as an external API it should be removed. |
+| UnusedClass.java:1:7:1:17 | UnusedClass | Unused class: UnusedClass is not referenced within this codebase. If not used as an external API it should be removed. |
diff --git a/java/ql/test/query-tests/DeadCode/DeadRefTypes/DeadRefTypes.qlref b/java/ql/test/query-tests/DeadCode/DeadRefTypes/DeadRefTypes.qlref
@@ -0,0 +1 @@
+Violations of Best Practice/Dead Code/DeadRefTypes.ql
diff --git a/java/ql/test/query-tests/DeadCode/DeadRefTypes/MyAnnotation.java b/java/ql/test/query-tests/DeadCode/DeadRefTypes/MyAnnotation.java
@@ -0,0 +1,2 @@
+public @interface MyAnnotation {
+}
diff --git a/java/ql/test/query-tests/DeadCode/DeadRefTypes/UnusedClass.java b/java/ql/test/query-tests/DeadCode/DeadRefTypes/UnusedClass.java
@@ -0,0 +1 @@
+class UnusedClass {}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+@MyAnnotation`
	`2`	`+class ClassWithAnnotation {`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+\| ClassWithAnnotatedMethod.java:1:7:1:30 \| ClassWithAnnotatedMethod \| Unused class: ClassWithAnnotatedMethod is not referenced within this codebase. If not used as an external API it should be removed. \|`
	`2`	`+\| UnusedClass.java:1:7:1:17 \| UnusedClass \| Unused class: UnusedClass is not referenced within this codebase. If not used as an external API it should be removed. \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Violations of Best Practice/Dead Code/DeadRefTypes.ql`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+public @interface MyAnnotation {`
	`2`	`+}`