Use TryGetValue

henrymercer · henrymercer · commit 0928c9398970 · 2024-01-23T20:43:19.000Z
diff --git a/csharp/autobuilder/Semmle.Autobuild.CSharp.Tests/BuildScripts.cs b/csharp/autobuilder/Semmle.Autobuild.CSharp.Tests/BuildScripts.cs
@@ -116,9 +116,8 @@ bool IBuildActions.DirectoryExists(string dir)
 
         string? IBuildActions.GetEnvironmentVariable(string name)
         {
-            if (!GetEnvironmentVariable.ContainsKey(name))
-                return null;
-            return GetEnvironmentVariable[name];
+            GetEnvironmentVariable.TryGetValue(name, out var ret);
+            return ret;
         }
 
         public string GetCurrentDirectory { get; set; } = "";

Original file line number	Diff line number	Diff line change
`@@ -116,9 +116,8 @@ bool IBuildActions.DirectoryExists(string dir)`
`116`	`116`
`117`	`117`	`string? IBuildActions.GetEnvironmentVariable(string name)`
`118`	`118`	`{`
`119`		`- if (!GetEnvironmentVariable.ContainsKey(name))`
`120`		`- return null;`
`121`		`- return GetEnvironmentVariable[name];`
	`119`	`+ GetEnvironmentVariable.TryGetValue(name, out var ret);`
	`120`	`+ return ret;`
`122`	`121`	`}`
`123`	`122`
`124`	`123`	`public string GetCurrentDirectory { get; set; } = "";`