Skip to content

Commit 0c5d642

Browse files
committed
C++: Rename SystemFunction and restore QLDoc
1 parent 6f03c3e commit 0c5d642

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

cpp/ql/lib/semmle/code/cpp/security/CommandExecution.qll

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@ import semmle.code.cpp.models.interfaces.SideEffect
66
import semmle.code.cpp.models.interfaces.Alias
77
import semmle.code.cpp.models.interfaces.CommandExecution
88

9-
class WrappedSystemFunction extends FunctionWithWrappers instanceof CommandExecutionFunction {
9+
/**
10+
* A function for running a command using a command interpreter.
11+
*/
12+
class SystemFunction extends FunctionWithWrappers instanceof CommandExecutionFunction {
1013
override predicate interestingArg(int arg) {
1114
exists(FunctionInput input |
1215
this.(CommandExecutionFunction).hasCommandArgument(input) and
@@ -160,7 +163,7 @@ predicate shellCommandPreface(string cmd, string flag) {
160163
*/
161164
predicate shellCommand(Expr command, string callChain) {
162165
// A call to a function like system()
163-
exists(WrappedSystemFunction systemFunction |
166+
exists(SystemFunction systemFunction |
164167
systemFunction.outermostWrapperFunctionCall(command, callChain)
165168
)
166169
or

0 commit comments

Comments
 (0)