C#: Re-introduce null check in cached entity hash code calculation.

michaelnebel · michaelnebel · commit 0cf00ebb5d3b · 2023-11-08T10:59:06.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction/Entities/Base/CachedEntity`1.cs b/csharp/extractor/Semmle.Extraction/Entities/Base/CachedEntity`1.cs
@@ -54,7 +54,7 @@ public string DebugContents
 
         public override bool NeedsPopulation { get; }
 
-        public override int GetHashCode() => Symbol.GetHashCode();
+        public override int GetHashCode() => Symbol is null ? 0 : Symbol.GetHashCode();
 
         public override bool Equals(object? obj)
         {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public string DebugContents`
`54`	`54`
`55`	`55`	`public override bool NeedsPopulation { get; }`
`56`	`56`
`57`		`- public override int GetHashCode() => Symbol.GetHashCode();`
	`57`	`+ public override int GetHashCode() => Symbol is null ? 0 : Symbol.GetHashCode();`
`58`	`58`
`59`	`59`	`public override bool Equals(object? obj)`
`60`	`60`	`{`