Skip to content

Commit 0dea5da

Browse files
Change import for consistency, fix some typos
1 parent 2be68b2 commit 0dea5da

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

java/ql/lib/semmle/code/java/security/AndroidCertificatePinningQuery.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import semmle.code.xml.AndroidManifest
55
import semmle.code.java.dataflow.TaintTracking
66
import semmle.code.java.frameworks.Networking
77
import semmle.code.java.security.Encryption
8-
import HttpsUrls
8+
import semmle.code.java.security.HttpsUrls
99

1010
/** An Android Network Security Configuration XML file. */
1111
class AndroidNetworkSecurityConfigFile extends XmlFile {
@@ -47,7 +47,7 @@ private predicate trustedDomainViaOkHttp(string domainName) {
4747
)
4848
}
4949

50-
/** Holds if the given domain name is trusted by some certifiacte pinning implementation. */
50+
/** Holds if the given domain name is trusted by some certificate pinning implementation. */
5151
predicate trustedDomain(string domainName) {
5252
trustedDomainViaXml(domainName)
5353
or
@@ -56,11 +56,11 @@ predicate trustedDomain(string domainName) {
5656

5757
/**
5858
* Holds if `setSocketFactory` is a call to `HttpsURLConnection.setSSLSocketFactory` or `HttpsURLConnection.setDefaultSSLSocketFactory`
59-
* that uses a socket factory derrived from a `TrustManager`.
59+
* that uses a socket factory derived from a `TrustManager`.
6060
* `default` is true if the default SSL socket factory for all URLs is being set.
6161
*/
6262
private predicate trustedSocketFactory(MethodAccess setSocketFactory, boolean default) {
63-
exists(MethodAccess getSocketFactory, MethodAccess initSslContext |
63+
exists(MethodAccess getSocketFactory, MethodAccess initSslContext |
6464
exists(Method m | setSocketFactory.getMethod().getASourceOverriddenMethod*() = m |
6565
default = true and
6666
m.getDeclaringType() instanceof HttpsUrlConnection and

0 commit comments

Comments
 (0)