Skip to content

Commit 0e24ed1

Browse files
geoffw0aschackmull
andauthored
Apply suggestions from code review
Co-authored-by: Anders Schack-Mulligen <[email protected]>
1 parent 1fece75 commit 0e24ed1

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ signature module Semantic {
276276
}
277277

278278
/**
279-
* A single update to a variable in the SSA form.
279+
* An SSA variable representing the value of an explicit update of the source variable.
280280
*/
281281
class SsaExplicitUpdate extends SsaVariable {
282282
/**
@@ -374,17 +374,21 @@ signature module LangSig<Semantic Sem, DeltaSig D> {
374374

375375
signature module BoundSig<LocationSig Location, Semantic Sem, DeltaSig D> {
376376
/**
377-
* A semantic bound, which defines a constraint on the possible values of an
378-
* expression.
377+
* A bound that the range analysis can infer for a variable. This includes
378+
* constant bounds represented by the abstract value zero, SSA bounds for when
379+
* a variable is bounded by the value of a different variable, and possibly
380+
* other abstract values that may be useful variable bounds. Since all bounds
381+
* are combined with an integer delta there's no need to represent constant
382+
* bounds other than zero.
379383
*/
380384
class SemBound {
381385
/**
382-
* Gets a string representation of the semantic bound.
386+
* Gets a string representation of this bound.
383387
*/
384388
string toString();
385389

386390
/**
387-
* Gets the location of the semantic bound.
391+
* Gets the location of this bound.
388392
*/
389393
Location getLocation();
390394

0 commit comments

Comments
 (0)