Go: ExternalAPIs

d10c · d10c · commit 0e9f816d232a · 2025-07-07T11:39:45.000+02:00
diff --git a/go/ql/lib/semmle/go/security/ExternalAPIs.qll b/go/ql/lib/semmle/go/security/ExternalAPIs.qll
@@ -187,9 +187,7 @@ private module UntrustedDataConfig implements DataFlow::ConfigSig {
 
   predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/go/ql/lib/semmle/go/security/ExternalAPIs.qll@212:36:212:80), Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/go/ql/lib/semmle/go/security/ExternalAPIs.qll@215:43:215:92)
-  }
+  predicate observeDiffInformedIncrementalMode() { any() }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -187,9 +187,7 @@ private module UntrustedDataConfig implements DataFlow::ConfigSig {`
`187`	`187`
`188`	`188`	`predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }`
`189`	`189`
`190`		`- predicate observeDiffInformedIncrementalMode() {`
`191`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/go/ql/lib/semmle/go/security/ExternalAPIs.qll@212:36:212:80), Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/go/ql/lib/semmle/go/security/ExternalAPIs.qll@215:43:215:92)`
`192`		`- }`
	`190`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
`193`	`191`	`}`
`194`	`192`
`195`	`193`	`/**`