Merge pull request #11708 from geoffw0/perf

MathiasVP · web-flow · commit 0f04e841a0b8 · 2022-12-15T16:56:35.000Z
Swift: Fix RemoteFlowSource performance issue.
diff --git a/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll b/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll
@@ -125,7 +125,8 @@ private class JsExportedSource extends RemoteFlowSource {
       base.getEnclosingDecl() instanceof JsExportedProto and
       adopter.getEnclosingDecl() instanceof JsExportedType
     |
-      this.asExpr().(MemberRefExpr).getMember() = adopter and adopter.getName() = base.getName()
+      this.asExpr().(MemberRefExpr).getMember() = adopter and
+      pragma[only_bind_out](adopter.getName()) = pragma[only_bind_out](base.getName())
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,8 @@ private class JsExportedSource extends RemoteFlowSource {`
`125`	`125`	`base.getEnclosingDecl() instanceof JsExportedProto and`
`126`	`126`	`adopter.getEnclosingDecl() instanceof JsExportedType`
`127`	`127`	`\|`
`128`		`- this.asExpr().(MemberRefExpr).getMember() = adopter and adopter.getName() = base.getName()`
	`128`	`+ this.asExpr().(MemberRefExpr).getMember() = adopter and`
	`129`	`+ pragma[only_bind_out](adopter.getName()) = pragma[only_bind_out](base.getName())`
`129`	`130`	`)`
`130`	`131`	`}`
`131`	`132`