Skip to content

Commit 12d8567

Browse files
committed
Address review comments
1 parent c717e34 commit 12d8567

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

csharp/ql/lib/semmle/code/csharp/commons/QualifiedName.qll

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ module QualifiedName<QualifiedNameInputSig Input> {
6767
predicate hasQualifiedName(Declaration d, string qualifier, string name) {
6868
d =
6969
any(ValueOrRefType vort |
70-
vort instanceof VoidType and
71-
qualifier = "System" and
72-
name = "Void"
73-
or
7470
vort =
7571
any(ArrayType at |
7672
exists(Type elementType, string name0 |
@@ -81,9 +77,6 @@ module QualifiedName<QualifiedNameInputSig Input> {
8177
or
8278
hasQualifiedName(vort.(TupleType).getUnderlyingType(), qualifier, name)
8379
or
84-
qualifier = "System" and
85-
name = "Nullable<" + getFullName(vort.(NullableType).getUnderlyingType()) + ">"
86-
or
8780
vort =
8881
any(UnboundGenericType ugt |
8982
exists(string name0 | name = name0 + Input::getUnboundGenericSuffix(ugt) |
@@ -112,10 +105,8 @@ module QualifiedName<QualifiedNameInputSig Input> {
112105
)
113106
)
114107
or
115-
not vort instanceof VoidType and
116108
not vort instanceof ArrayType and
117109
not vort instanceof TupleType and
118-
not vort instanceof NullableType and
119110
not vort instanceof UnboundGenericType and
120111
not vort instanceof ConstructedType and
121112
(

0 commit comments

Comments
 (0)