Skip to content

Commit 137403f

Browse files
committed
Java: Move more tests to use the try_use_java11() helper.
This is in preparation of executing these tests on GH-hosted M1 runners, where we need to have architecture-specific path handling. It's nicer to fix all of this in one place (the helper), than to run around fixing individual tests.
1 parent ab64d9a commit 137403f

File tree

8 files changed

+8
-33
lines changed
  • java/ql/integration-tests/all-platforms/java
    • android-sample-kotlin-build-script-no-wrapper
    • android-sample-kotlin-build-script
    • android-sample-no-wrapper
    • android-sample-old-style-kotlin-build-script-no-wrapper
    • android-sample-old-style-kotlin-build-script
    • android-sample-old-style-no-wrapper
    • android-sample-old-style
    • android-sample

8 files changed

+8
-33
lines changed

java/ql/integration-tests/all-platforms/java/android-sample-kotlin-build-script-no-wrapper/test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from create_database_utils import *
44

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
5+
try_use_java11()
96

107
run_codeql_database_create([], lang="java")

java/ql/integration-tests/all-platforms/java/android-sample-kotlin-build-script/test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from create_database_utils import *
44

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
5+
try_use_java11()
96

107
run_codeql_database_create([], lang="java")

java/ql/integration-tests/all-platforms/java/android-sample-no-wrapper/test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from create_database_utils import *
44

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
5+
try_use_java11()
96

107
run_codeql_database_create([], lang="java")
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
import sys
2-
32
from create_database_utils import *
43

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
4+
try_use_java11()
95

106
run_codeql_database_create([], lang="java")

java/ql/integration-tests/all-platforms/java/android-sample-old-style-kotlin-build-script/test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from create_database_utils import *
44

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
5+
try_use_java11()
96

107
run_codeql_database_create([], lang="java")

java/ql/integration-tests/all-platforms/java/android-sample-old-style-no-wrapper/test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from create_database_utils import *
44

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
5+
try_use_java11()
96

107
run_codeql_database_create([], lang="java")

java/ql/integration-tests/all-platforms/java/android-sample-old-style/test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from create_database_utils import *
44

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
5+
try_use_java11()
96

107
run_codeql_database_create([], lang="java")

java/ql/integration-tests/all-platforms/java/android-sample/test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from create_database_utils import *
44

5-
if "JAVA_HOME_11_X64" in os.environ:
6-
os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_11_X64"]
7-
sep = ";" if platform.system() == "Windows" else ":"
8-
os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]])
5+
try_use_java11()
96

107
run_codeql_database_create([], lang="java")

0 commit comments

Comments
 (0)