Fix CodeQL warning

tiferet · tiferet · commit 13cb0ab5540f · 2022-11-15T17:32:30.000-08:00
diff --git a/javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/extraction/ExtractEndpointDataTraining.qll b/javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/extraction/ExtractEndpointDataTraining.qll
@@ -195,7 +195,7 @@ query predicate reformattedTrainingEndpoints(
       // Don't surface endpoint filters as notASinkReasons, because they were previously not surfaced.
       // TODO: Experiment with surfacing these to the modeling code by removing the following line (and then make
       // EndpointFilterCharacteristic private).
-      not exists(EndpointFilterCharacteristic filterCharacteristic | value = filterCharacteristic) and
+      not value instanceof EndpointFilterCharacteristic and
       valueType = "string"
     )
   )

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ query predicate reformattedTrainingEndpoints(`
`195`	`195`	`// Don't surface endpoint filters as notASinkReasons, because they were previously not surfaced.`
`196`	`196`	`// TODO: Experiment with surfacing these to the modeling code by removing the following line (and then make`
`197`	`197`	`// EndpointFilterCharacteristic private).`
`198`		`- not exists(EndpointFilterCharacteristic filterCharacteristic \| value = filterCharacteristic) and`
	`198`	`+ not value instanceof EndpointFilterCharacteristic and`
`199`	`199`	`valueType = "string"`
`200`	`200`	`)`
`201`	`201`	`)`