Rust: Effect of lifting content reads as taint steps.

Author: geoffw0

rust/ql/test/library-tests/dataflow/taint/inline-taint-flow.expected

@@ -109,10 +109,6 @@ nodes
 | main.rs:116:15:116:29 | source_tuple(...) | semmle.label | source_tuple(...) |
 subpaths
 testFailures
-| main.rs:102:14:102:30 | ... .0 | Fixed missing result: hasTaintFlow=2 |
-| main.rs:103:14:103:30 | ... .1 | Fixed missing result: hasTaintFlow=2 |
-| main.rs:115:14:115:68 | ... .0 | Fixed missing result: hasTaintFlow=4 |
-| main.rs:116:14:116:68 | ... .1 | Fixed missing result: hasTaintFlow=4 |
 #select
 | main.rs:13:10:13:14 | ... + ... | main.rs:12:13:12:22 | source(...) | main.rs:13:10:13:14 | ... + ... | $@ | main.rs:12:13:12:22 | source(...) | source(...) |
 | main.rs:17:10:17:10 | b | main.rs:15:17:15:26 | source(...) | main.rs:17:10:17:10 | b | $@ | main.rs:15:17:15:26 | source(...) | source(...) |

rust/ql/test/library-tests/dataflow/taint/main.rs

@@ -99,8 +99,8 @@ mod tuples {
         sink((source_string(1), "".to_string()).1);
 
         sink(source_tuple(2)); // $ hasValueFlow=2
-        sink(source_tuple(2).0); // $ MISSING: hasTaintFlow=2
-        sink(source_tuple(2).1); // $ MISSING: hasTaintFlow=2
+        sink(source_tuple(2).0); // $ hasTaintFlow=2
+        sink(source_tuple(2).1); // $ hasTaintFlow=2
 
         sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())));
         sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())).0);
@@ -112,8 +112,8 @@ mod tuples {
 
         sink((source_tuple(4), ("".to_string(), "".to_string())));
         sink((source_tuple(4), ("".to_string(), "".to_string())).0); // $ hasValueFlow=4
-        sink((source_tuple(4), ("".to_string(), "".to_string())).0.0); // $ MISSING: hasTaintFlow=4
-        sink((source_tuple(4), ("".to_string(), "".to_string())).0.1); // $ MISSING: hasTaintFlow=4
+        sink((source_tuple(4), ("".to_string(), "".to_string())).0.0); // $ hasTaintFlow=4
+        sink((source_tuple(4), ("".to_string(), "".to_string())).0.1); // $ hasTaintFlow=4
         sink((source_tuple(4), ("".to_string(), "".to_string())).1);
         sink((source_tuple(4), ("".to_string(), "".to_string())).1.0);
         sink((source_tuple(4), ("".to_string(), "".to_string())).1.1);