Skip to content

Commit 15b965b

Browse files
committed
rename verifies() to verifiesSignature()
1 parent c43d086 commit 15b965b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ruby/ql/lib/codeql/ruby/Concepts.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1311,7 +1311,7 @@ class JwtDecoding extends DataFlow::Node instanceof JwtDecoding::Range {
13111311
DataFlow::Node getOptions() { result = super.getOptions() }
13121312

13131313
/** Checks if the signature gets verified while decoding. */
1314-
predicate verifies() { super.verifies() }
1314+
predicate verifiesSignature() { super.verifiesSignature() }
13151315
}
13161316

13171317
/** Provides a class for modeling new Jwt token encoding APIs. */
@@ -1336,6 +1336,6 @@ module JwtDecoding {
13361336
abstract DataFlow::Node getOptions();
13371337

13381338
/** Checks if the signature gets verified while decoding. */
1339-
abstract predicate verifies();
1339+
abstract predicate verifiesSignature();
13401340
}
13411341
}

ruby/ql/lib/codeql/ruby/frameworks/Jwt.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ module Jwt {
4545

4646
override DataFlow::Node getOptions() { result = this.getArgument(3) }
4747

48-
override predicate verifies() {
48+
override predicate verifiesSignature() {
4949
not this.getArgument(2).getConstantValue().isBoolean(false) and
5050
not this.getAlgorithm().getConstantValue().isStringlikeValue("none")
5151
or

ruby/ql/src/experimental/cwe-347/MissingJWTVerification.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@
1212
private import codeql.ruby.Concepts
1313

1414
from JwtDecoding jwtDecoding
15-
where not jwtDecoding.verifies()
15+
where not jwtDecoding.verifiesSignature()
1616
select jwtDecoding.getPayload(), "is not verified with a cryptographic secret or public key."

0 commit comments

Comments
 (0)