Skip to content

Commit 166a368

Browse files
committed
Use standard variable names for hasLocationInfo
This makes them match the QLDoc and also other implementations of `hasLocationInfo`.
1 parent 1a65a27 commit 166a368

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

go/ql/lib/semmle/go/dataflow/internal/DataFlowUtil.qll

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,10 @@ class Content extends TContent {
161161
* For more information, see
162162
* [Locations](https://codeql.github.com/docs/writing-codeql-queries/providing-locations-in-codeql-queries/).
163163
*/
164-
predicate hasLocationInfo(string path, int sl, int sc, int el, int ec) {
165-
path = "" and sl = 0 and sc = 0 and el = 0 and ec = 0
164+
predicate hasLocationInfo(
165+
string filepath, int startline, int startcolumn, int endline, int endcolumn
166+
) {
167+
filepath = "" and startline = 0 and startcolumn = 0 and endline = 0 and endcolumn = 0
166168
}
167169
}
168170

@@ -254,8 +256,10 @@ class ContentSet instanceof Content {
254256
* For more information, see
255257
* [Locations](https://codeql.github.com/docs/writing-codeql-queries/providing-locations-in-codeql-queries/).
256258
*/
257-
predicate hasLocationInfo(string path, int sl, int sc, int el, int ec) {
258-
super.hasLocationInfo(path, sl, sc, el, ec)
259+
predicate hasLocationInfo(
260+
string filepath, int startline, int startcolumn, int endline, int endcolumn
261+
) {
262+
super.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
259263
}
260264
}
261265

0 commit comments

Comments
 (0)