Ruby: PolynomialReDoS: keep excluded

d10c · d10c · commit 168a3ae253ff · 2025-07-04T16:19:32.000+02:00
diff --git a/ruby/ql/lib/codeql/ruby/security/regexp/PolynomialReDoSQuery.qll b/ruby/ql/lib/codeql/ruby/security/regexp/PolynomialReDoSQuery.qll
@@ -18,10 +18,6 @@ private module PolynomialReDoSConfig implements DataFlow::ConfigSig {
   predicate isSink(DataFlow::Node sink) { sink instanceof Sink }
 
   predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
-
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 selects sink.getHighlight (/Users/d10c/src/semmle-code/ql/ruby/ql/src/queries/security/cwe-1333/PolynomialReDoS.ql@27:8:27:30), Column 5 selects sink.getRegExp (/Users/d10c/src/semmle-code/ql/ruby/ql/src/queries/security/cwe-1333/PolynomialReDoS.ql@29:67:29:72)
-  }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,6 @@ private module PolynomialReDoSConfig implements DataFlow::ConfigSig {`
`18`	`18`	`predicate isSink(DataFlow::Node sink) { sink instanceof Sink }`
`19`	`19`
`20`	`20`	`predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }`
`21`		`-`
`22`		`- predicate observeDiffInformedIncrementalMode() {`
`23`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 selects sink.getHighlight (/Users/d10c/src/semmle-code/ql/ruby/ql/src/queries/security/cwe-1333/PolynomialReDoS.ql@27:8:27:30), Column 5 selects sink.getRegExp (/Users/d10c/src/semmle-code/ql/ruby/ql/src/queries/security/cwe-1333/PolynomialReDoS.ql@29:67:29:72)`
`24`		`- }`
`25`	`21`	`}`
`26`	`22`
`27`	`23`	`/**`