C++: Better solution.

geoffw0 · geoffw0 · commit 1d4631e231dd · 2022-12-07T18:00:38.000Z
diff --git a/cpp/ql/src/Best Practices/Likely Errors/OffsetUseBeforeRangeCheck.ql b/cpp/ql/src/Best Practices/Likely Errors/OffsetUseBeforeRangeCheck.ql
@@ -15,7 +15,7 @@
 
 import cpp
 
-bindingset[v, before]
+pragma[nomagic]
 predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {
   exists(LogicalAndExpr andexpr |
     access.getArrayOffset() = v.getAnAccess() and
@@ -24,7 +24,7 @@ predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {
   )
 }
 
-bindingset[v, after]
+pragma[nomagic]
 predicate afterArrayAccess(Variable v, ArrayExpr access, Expr after) {
   exists(LogicalAndExpr andexpr |
     access.getArrayOffset() = v.getAnAccess() and

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`import cpp`
`17`	`17`
`18`		`-bindingset[v, before]`
	`18`	`+pragma[nomagic]`
`19`	`19`	`predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {`
`20`	`20`	`exists(LogicalAndExpr andexpr \|`
`21`	`21`	`access.getArrayOffset() = v.getAnAccess() and`
`@@ -24,7 +24,7 @@ predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {`
`24`	`24`	`)`
`25`	`25`	`}`
`26`	`26`
`27`		`-bindingset[v, after]`
	`27`	`+pragma[nomagic]`
`28`	`28`	`predicate afterArrayAccess(Variable v, ArrayExpr access, Expr after) {`
`29`	`29`	`exists(LogicalAndExpr andexpr \|`
`30`	`30`	`access.getArrayOffset() = v.getAnAccess() and`