C#: Restrict refReadBeforeWrite

hvitved · hvitved · commit 1d654d1eac0f · 2021-11-24T13:43:14.000+01:00
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll
@@ -171,7 +171,8 @@ private module SourceVariableImpl {
       def.getTarget() = lv and
       lv.isRef() and
       lv = v.getAssignable() and
-      bb.getNode(i) = def.getAControlFlowNode()
+      bb.getNode(i) = def.getAControlFlowNode() and
+      not def.getAssignment() instanceof LocalVariableDeclAndInitExpr
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,8 @@ private module SourceVariableImpl {`
`171`	`171`	`def.getTarget() = lv and`
`172`	`172`	`lv.isRef() and`
`173`	`173`	`lv = v.getAssignable() and`
`174`		`- bb.getNode(i) = def.getAControlFlowNode()`
	`174`	`+ bb.getNode(i) = def.getAControlFlowNode() and`
	`175`	`+ not def.getAssignment() instanceof LocalVariableDeclAndInitExpr`
`175`	`176`	`)`
`176`	`177`	`}`
`177`	`178`