Skip to content

Commit 1e3e481

Browse files
committed
Rewording
1 parent 47c851e commit 1e3e481

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed

java/ql/src/Security/CWE/CWE-927/ImplicitPendingIntents.qhelp

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,18 @@
1010
the application that created it, and with its same privileges.</p>
1111
<p>If a <code>PendingIntent</code> is configured to be mutable, the fields of its internal Intent can be changed by the
1212
receiving application if they were not previously set. This means that a mutable <code>PendingIntent</code> that has
13-
not defined a destination component (that is, an implicit <code>PendingIntent</code>) can be directed to any component
14-
by the receiving application, and execute an arbitrary action with the privileges of the application that created it.</p>
15-
<p>If an implicit <code>PendingIntent</code> is wrapped and sent as an extra of an Intent that can be intercepted (that
16-
is, again, an implicit Intent), any malicious application could obtain the <code>PendingIntent</code>, modify the
17-
underlying Intent with an arbitrary destination component, and execute the desired action with elevated privileges.
18-
This could give the malicious application access to private components of the victim application, or the ability to
19-
perform actions without having the necessary permissions.</p>
13+
not defined a destination component (that is, an implicit <code>PendingIntent</code>) can be altered to execute an
14+
arbitrary action with the privileges of the application that created it.</p>
15+
<p>If an implicit PendingIntent is obtainable by a malicious application by any of the following means:</p>
16+
<ul>
17+
<li>It is wrapped and sent as an extra of another implicit Intent</li>
18+
<li>It is sent as the action of a Slide</li>
19+
<li>It is sent as the action of a Notification</li>
20+
</ul>
21+
<p></p>
22+
<p>the attacker could modify the underlying Intent and execute an arbitrary action with elevated privileges.
23+
This could give the malicious application access to private components of the victim application,
24+
or the ability to perform actions without having the necessary permissions.</p>
2025
</overview>
2126

2227
<recommendation>

java/ql/src/Security/CWE/CWE-927/ImplicitPendingIntents.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/**
22
* @name Use of implicit Pending Intents
3-
* @description Implicit and mutable PendingIntents being wrapped and sent in another implicit
4-
* Intent may provide access to internal components of the application or cause other
5-
* unintended effects.
3+
* @description Implicit and mutable PendingIntents being sent to an unspecified third party
4+
* component may provide access to internal components of the application or cause
5+
* other unintended effects.
66
* @kind path-problem
77
* @problem.severity error
88
* @security-severity 8.2

java/ql/src/change-notes/2021-09-30-android-implicit-pendingintents.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
category: newQuery
33
---
44
* A new query "Use of implicit Pending Intents" (`java/android/pending-intents`) has been added.
5-
This query finds implicit and mutable PendingIntents being wrapped and sent in another implicit Intent,
5+
This query finds implicit and mutable PendingIntents being sent to an unspecified third party component,
66
which can provide access to internal components of the application or cause other unintended
77
effects.

0 commit comments

Comments
 (0)