Skip to content

Commit 1ec3e87

Browse files
yoffadityasharad
andauthored
Apply suggestions from code review
Co-authored-by: Aditya Sharad <[email protected]>
1 parent e7bb47f commit 1ec3e87

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

actions/ql/src/Security/CWE-275/MissingActionsPermissions.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ string jobNeedsPersmission(Job job) {
3030
actionsPermissionsDataModel(versionedAction(stepUses(stepInJob(job))), result)
3131
}
3232

33+
/** Gets a suggestion for the minimal token permissions for `job`, as a JSON string. */
3334
string permissionsForJob(Job job) {
3435
result =
3536
"{" + concat(string permission | permission = jobNeedsPersmission(job) | permission, ", ") + "}"
@@ -46,4 +47,4 @@ where
4647
) and
4748
permissions = permissionsForJob(job)
4849
select job,
49-
"Actions Job or Workflow does not set permissions. A minimal set might be " + permissions
50+
"Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: " + permissions

0 commit comments

Comments
 (0)