Apply suggestions from code review

Co-authored-by: Owen Mansel-Chan <[email protected]>

Author: maikypedia

go/ql/src/experimental/CWE-287/ImproperLdapAuth.qll

@@ -22,12 +22,9 @@ abstract class LdapSanitizer extends DataFlow::Node { }
  */
 private class GoLdapBindSink extends LdapAuthSink {
   GoLdapBindSink() {
-    exists(Method meth, string base, string t, string m |
-      t = ["Conn"] and
-      meth.hasQualifiedName(["gopkg.in/ldap.v2"], t, m) and
+    exists(Method meth |
+      meth.hasQualifiedName("gopkg.in/ldap.v2", "Conn", "Bind") and
       this = meth.getACall().getArgument(1)
-    |
-      base = ["Bind"] and m = base
     )
   }
 }

go/ql/src/experimental/CWE-287/examples/LdapAuthGood.go

@@ -9,7 +9,7 @@ func good() interface{} {
 	defer l.Close()
 
 	if bindPassword != "" {
-		l.Bind(bindDN, bindPassword)
+		err = l.Bind("cn=admin,dc=example,dc=com", bindPassword)
 		if err != nil {
 			log.Fatalf("LDAP bind failed: %v", err)
 		}

go/ql/test/experimental/CWE-287/ImproperLdapAuth.go

@@ -95,5 +95,5 @@ func main() {
 	bad(nil, nil)
 	good1(nil, nil)
 	good2(nil, nil)
-	bad2(nil, nil)
+	bad2(nil)
 }