Merge pull request #17744 from geoffw0/unusedvar5

geoffw0 · web-flow · commit 25b592fc8958 · 2024-10-14T16:20:52.000+01:00
Rust: Unused variable follow-up work
diff --git a/rust/ql/test/query-tests/unusedentities/main.rs b/rust/ql/test/query-tests/unusedentities/main.rs
@@ -111,7 +111,7 @@ fn arrays() {
 
     println!("lets use {:?}", js);
 
-    for k // SPURIOUS: unused variable [macros not yet supported]
+    for k
 	in ks
 	{
         println!("lets use {}", k); // [unreachable FALSE POSITIVE]
@@ -166,12 +166,12 @@ fn loops() {
 
     for _ in 1..10 {}
 
-    for x // SPURIOUS: unused variable [macros not yet supported]
+    for x
     in 1..10 {
         println!("x is {}", x);
     }
 
-    for x // SPURIOUS: unused variable [macros not yet supported]
+    for x
     in 1..10 {
         assert!(x != 11);
     }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ fn arrays() {`
`111`	`111`
`112`	`112`	`println!("lets use {:?}", js);`
`113`	`113`
`114`		`- for k // SPURIOUS: unused variable [macros not yet supported]`
	`114`	`+ for k`
`115`	`115`	`in ks`
`116`	`116`	`{`
`117`	`117`	`println!("lets use {}", k); // [unreachable FALSE POSITIVE]`
`@@ -166,12 +166,12 @@ fn loops() {`
`166`	`166`
`167`	`167`	`for _ in 1..10 {}`
`168`	`168`
`169`		`- for x // SPURIOUS: unused variable [macros not yet supported]`
	`169`	`+ for x`
`170`	`170`	`in 1..10 {`
`171`	`171`	`println!("x is {}", x);`
`172`	`172`	`}`
`173`	`173`
`174`		`- for x // SPURIOUS: unused variable [macros not yet supported]`
	`174`	`+ for x`
`175`	`175`	`in 1..10 {`
`176`	`176`	`assert!(x != 11);`
`177`	`177`	`}`