Skip to content

Commit 2796597

Browse files
committed
Code quality improvements.
1 parent 0bf1ed1 commit 2796597

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module Input implements InputSig<Location, DataFlowImplSpecific::CsharpDataFlow>
1818

1919
predicate neutralElement(SummarizedCallableBase c, string kind, string provenance, boolean isExact) {
2020
interpretNeutral(c, kind, provenance) and
21-
// isExact has not been implemented yet.
21+
// isExact is not needed for C#.
2222
isExact = false
2323
}
2424

go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImpl.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module Input implements InputSig<Location, DataFlowImplSpecific::GoDataFlow> {
3030
neutralModel(namespace, type, name, signature, kind, provenance) and
3131
c.asFunction() = interpretElement(namespace, type, false, name, signature, "").asEntity()
3232
) and
33-
// isExact has not been implemented yet.
33+
// isExact is not needed for Go.
3434
isExact = false
3535
}
3636

@@ -315,7 +315,7 @@ module Private {
315315
* and with provenance `provenance`.
316316
*/
317317
predicate neutralElement(Input::SummarizedCallableBase c, string kind, string provenance) {
318-
Input::neutralElement(c, kind, provenance, false)
318+
Input::neutralElement(c, kind, provenance, _)
319319
}
320320
}
321321

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
private import java
22
private import DataFlowPrivate
33
private import DataFlowUtil
4-
private import semmle.code.java.dataflow.ExternalFlow as ExternalFlow
54
private import semmle.code.java.dataflow.InstanceAccess
65
private import semmle.code.java.dataflow.internal.FlowSummaryImpl as Impl
76
private import semmle.code.java.dispatch.VirtualDispatch as VirtualDispatch

java/ql/test/utils/modelgenerator/dataflow/p/Sinks.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ public void sink(Object o) {}
2121
// neutral=p;Sinks;sink2;(Object);summary;df-generated
2222
public void sink2(Object o) {}
2323

24-
// Defined as sink neutral file in the model file next to the
25-
// neutral test.
24+
// Defined as sink neutral in the file next to the neutral summary test.
2625
// neutral=p;Sinks;nosink;(Object);summary;df-generated
2726
public void nosink(Object o) {}
2827

0 commit comments

Comments
 (0)